Skip to content

Commit 411dccf

Browse files
Minghao Chivinodkoul
authored andcommitted
dmaengine: idxd: Remove unnecessary synchronize_irq() before free_irq()
Calling synchronize_irq() right before free_irq() is quite useless. On one hand the IRQ can easily fire again before free_irq() is entered, on the other hand free_irq() itself calls synchronize_irq() internally (in a race condition free way), before any state associated with the IRQ is freed. Signed-off-by: Minghao Chi <[email protected]> Link: https://lore.kernel.org/r/[email protected] Acked-by: Dave Jiang <[email protected]> Signed-off-by: Vinod Koul <[email protected]>
1 parent 2112b8f commit 411dccf

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/dma/idxd/device.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1179,7 +1179,6 @@ void idxd_wq_free_irq(struct idxd_wq *wq)
11791179
if (wq->type != IDXD_WQT_KERNEL)
11801180
return;
11811181

1182-
synchronize_irq(ie->vector);
11831182
free_irq(ie->vector, ie);
11841183
idxd_flush_pending_descs(ie);
11851184
if (idxd->request_int_handles)

0 commit comments

Comments
 (0)