Skip to content

Commit 3ada0b3

Browse files
kuba-moodavem330
authored andcommitted
netlink: specs: ovs: remove fixed header fields from attrs
Op's "attributes" list is a workaround for families with a single attr set. We don't want to render a single huge request structure, the same for each op since we know that most ops accept only a small set of attributes. "Attributes" list lets us narrow down the attributes to what op acctually pays attention to. It doesn't make sense to put names of fixed headers in there. They are not "attributes" and we can't really narrow down the struct members. Remove the fixed header fields from attrs for ovs families in preparation for C codegen support. Reviewed-by: Donald Hunter <[email protected]> Signed-off-by: Jakub Kicinski <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 283f105 commit 3ada0b3

File tree

3 files changed

+0
-9
lines changed

3 files changed

+0
-9
lines changed

Documentation/netlink/specs/ovs_datapath.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ operations:
142142
do:
143143
request:
144144
attributes:
145-
- dp-ifindex
146145
- name
147146
- upcall-pid
148147
- user-features
@@ -154,7 +153,6 @@ operations:
154153
do:
155154
request:
156155
attributes:
157-
- dp-ifindex
158156
- name
159157

160158
mcast-groups:

Documentation/netlink/specs/ovs_flow.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -947,13 +947,11 @@ operations:
947947
do: &flow-get-op
948948
request:
949949
attributes:
950-
- dp-ifindex
951950
- key
952951
- ufid
953952
- ufid-flags
954953
reply:
955954
attributes:
956-
- dp-ifindex
957955
- key
958956
- ufid
959957
- mask
@@ -968,7 +966,6 @@ operations:
968966
do:
969967
request:
970968
attributes:
971-
- dp-ifindex
972969
- key
973970
- ufid
974971
- mask

Documentation/netlink/specs/ovs_vport.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,6 @@ operations:
135135
- name
136136
- type
137137
- upcall-pid
138-
- dp-ifindex
139138
- ifindex
140139
- options
141140
-
@@ -146,7 +145,6 @@ operations:
146145
do:
147146
request:
148147
attributes:
149-
- dp-ifindex
150148
- port-no
151149
- type
152150
- name
@@ -158,11 +156,9 @@ operations:
158156
do: &vport-get-op
159157
request:
160158
attributes:
161-
- dp-ifindex
162159
- name
163160
reply: &dev-all
164161
attributes:
165-
- dp-ifindex
166162
- port-no
167163
- type
168164
- name

0 commit comments

Comments
 (0)