Skip to content

Commit 37a826d

Browse files
arndbdavem330
authored andcommitted
net: dsa: qca8k: add CONFIG_LEDS_TRIGGERS dependency
Without LED triggers, the driver now fails to build: drivers/net/dsa/qca/qca8k-leds.c: In function 'qca8k_parse_port_leds': drivers/net/dsa/qca/qca8k-leds.c:403:31: error: 'struct led_classdev' has no member named 'hw_control_is_supported' 403 | port_led->cdev.hw_control_is_supported = qca8k_cled_hw_control_is_supported; | ^ There is a mix of 'depends on' and 'select' for LEDS_TRIGGERS, so it's not clear what we should use here, but in general using 'depends on' causes fewer problems, so use that. Fixes: e025664 ("net: dsa: qca8k: implement hw_control ops") Signed-off-by: Arnd Bergmann <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent f93b30e commit 37a826d

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/net/dsa/qca/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ config NET_DSA_QCA8K_LEDS_SUPPORT
2020
bool "Qualcomm Atheros QCA8K Ethernet switch family LEDs support"
2121
depends on NET_DSA_QCA8K
2222
depends on LEDS_CLASS=y || LEDS_CLASS=NET_DSA_QCA8K
23+
depends on LEDS_TRIGGERS
2324
help
2425
This enabled support for LEDs present on the Qualcomm Atheros
2526
QCA8K Ethernet switch chips.

0 commit comments

Comments
 (0)