Skip to content

Commit 371fd7b

Browse files
GustavoARSilvamarckleinebudde
authored andcommitted
can: dev: can_restart(): remove unused code
Value assigned to variable err is overwritten at line 562: err = priv->do_set_mode(dev, CAN_MODE_START); before it can be used. Also, notice that this code has been there since 2014. Addresses-Coverity-ID: 1227031 Signed-off-by: Gustavo A. R. Silva <[email protected]> Signed-off-by: Marc Kleine-Budde <[email protected]>
1 parent 2282001 commit 371fd7b

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/net/can/dev.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -553,10 +553,9 @@ static void can_restart(struct net_device *dev)
553553

554554
/* send restart message upstream */
555555
skb = alloc_can_err_skb(dev, &cf);
556-
if (!skb) {
557-
err = -ENOMEM;
556+
if (!skb)
558557
goto restart;
559-
}
558+
560559
cf->can_id |= CAN_ERR_RESTARTED;
561560

562561
netif_rx(skb);

0 commit comments

Comments
 (0)