Skip to content

Commit 355f948

Browse files
hkallweitdavem330
authored andcommitted
r8169: silence sparse warning in rtl8169_start_xmit
The opts[] array is of type u32. Therefore remove the wrong cpu_to_le32(). The opts[] array members are converted to little endian later when being assigned to the respective descriptor fields. This is not a new issue, it just popped up due to r8169.c having been renamed and more thoroughly checked. Due to the renaming this patch applies to net-next only. Reported-by: kbuild test robot <[email protected]> Signed-off-by: Heiner Kallweit <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent ec01147 commit 355f948

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/realtek/r8169_main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5621,7 +5621,7 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
56215621
if (unlikely(le32_to_cpu(txd->opts1) & DescOwn))
56225622
goto err_stop_0;
56235623

5624-
opts[1] = cpu_to_le32(rtl8169_tx_vlan_tag(skb));
5624+
opts[1] = rtl8169_tx_vlan_tag(skb);
56255625
opts[0] = DescOwn;
56265626

56275627
if (rtl_chip_supports_csum_v2(tp)) {

0 commit comments

Comments
 (0)