Skip to content

Commit 3551ff9

Browse files
committed
drm/i915/gen11: Moving WAs to rcs_engine_wa_init()
This are register of render engine, so after a render reset those would return to the default value and init_clock_gating() is not called for single engine reset. So here moving it rcs_engine_wa_init() that will guarantee that this WAs will not be lost. Cc: Matt Roper <[email protected]> Signed-off-by: José Roberto de Souza <[email protected]> Reviewed-by: Matt Roper <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 9b234d2 commit 3551ff9

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

drivers/gpu/drm/i915/gt/intel_workarounds.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1454,6 +1454,21 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
14541454
GEN11_SCRATCH2,
14551455
GEN11_COHERENT_PARTIAL_WRITE_MERGE_ENABLE,
14561456
0);
1457+
1458+
/* WaEnable32PlaneMode:icl */
1459+
wa_masked_en(wal, GEN9_CSFE_CHICKEN1_RCS,
1460+
GEN11_ENABLE_32_PLANE_MODE);
1461+
1462+
/*
1463+
* Wa_1408615072:icl,ehl (vsunit)
1464+
* Wa_1407596294:icl,ehl (hsunit)
1465+
*/
1466+
wa_masked_en(wal, UNSLICE_UNIT_LEVEL_CLKGATE,
1467+
VSUNIT_CLKGATE_DIS | HSUNIT_CLKGATE_DIS);
1468+
1469+
/* Wa_1407352427:icl,ehl */
1470+
wa_masked_en(wal, UNSLICE_UNIT_LEVEL_CLKGATE2,
1471+
PSDUNIT_CLKGATE_DIS);
14571472
}
14581473

14591474
if (IS_GEN_RANGE(i915, 9, 11)) {

drivers/gpu/drm/i915/intel_pm.c

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6806,21 +6806,6 @@ static void icl_init_clock_gating(struct drm_i915_private *dev_priv)
68066806
I915_WRITE(GEN10_DFR_RATIO_EN_AND_CHICKEN,
68076807
I915_READ(GEN10_DFR_RATIO_EN_AND_CHICKEN) & ~DFR_DISABLE);
68086808

6809-
/* WaEnable32PlaneMode:icl */
6810-
I915_WRITE(GEN9_CSFE_CHICKEN1_RCS,
6811-
_MASKED_BIT_ENABLE(GEN11_ENABLE_32_PLANE_MODE));
6812-
6813-
/*
6814-
* Wa_1408615072:icl,ehl (vsunit)
6815-
* Wa_1407596294:icl,ehl (hsunit)
6816-
*/
6817-
intel_uncore_rmw(&dev_priv->uncore, UNSLICE_UNIT_LEVEL_CLKGATE,
6818-
0, VSUNIT_CLKGATE_DIS | HSUNIT_CLKGATE_DIS);
6819-
6820-
/* Wa_1407352427:icl,ehl */
6821-
intel_uncore_rmw(&dev_priv->uncore, UNSLICE_UNIT_LEVEL_CLKGATE2,
6822-
0, PSDUNIT_CLKGATE_DIS);
6823-
68246809
/*Wa_14010594013:icl, ehl */
68256810
intel_uncore_rmw(&dev_priv->uncore, GEN8_CHICKEN_DCPR_1,
68266811
0, CNL_DELAY_PMRSP);

0 commit comments

Comments
 (0)