Skip to content

Commit 2cd0e54

Browse files
Kefeng Wangcminyard
authored andcommitted
ipmi_ssif: fix unexpected driver unregister warning
If platform_driver_register() fails from init_ipmi_ssif(), platform_driver_unregister() called unconditionally will trigger following warning, ipmi_ssif: Unable to register driver: -12 ------------[ cut here ]------------ Unexpected driver unregister! WARNING: CPU: 1 PID: 6305 at drivers/base/driver.c:193 driver_unregister+0x60/0x70 drivers/base/driver.c:193 Fix it by adding platform_registered variable, only unregister platform driver when it is already successfully registered. Reported-by: Hulk Robot <[email protected]> Signed-off-by: Kefeng Wang <[email protected]> Message-Id: <[email protected]> Signed-off-by: Corey Minyard <[email protected]>
1 parent dd7450c commit 2cd0e54

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/char/ipmi/ipmi_ssif.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,6 +303,7 @@ struct ssif_info {
303303
((unsigned int) atomic_read(&(ssif)->stats[SSIF_STAT_ ## stat]))
304304

305305
static bool initialized;
306+
static bool platform_registered;
306307

307308
static void return_hosed_msg(struct ssif_info *ssif_info,
308309
struct ipmi_smi_msg *msg);
@@ -2088,6 +2089,8 @@ static int init_ipmi_ssif(void)
20882089
rv = platform_driver_register(&ipmi_driver);
20892090
if (rv)
20902091
pr_err("Unable to register driver: %d\n", rv);
2092+
else
2093+
platform_registered = true;
20912094
}
20922095

20932096
ssif_i2c_driver.address_list = ssif_address_list();
@@ -2111,7 +2114,7 @@ static void cleanup_ipmi_ssif(void)
21112114

21122115
kfree(ssif_i2c_driver.address_list);
21132116

2114-
if (ssif_trydmi)
2117+
if (ssif_trydmi && platform_registered)
21152118
platform_driver_unregister(&ipmi_driver);
21162119

21172120
free_ssif_clients();

0 commit comments

Comments
 (0)