Skip to content

Commit 2c1e1b9

Browse files
rddunlapSaeed Mahameed
authored andcommitted
net: mlx5: eliminate anonymous module_init & module_exit
Eliminate anonymous module_init() and module_exit(), which can lead to confusion or ambiguity when reading System.map, crashes/oops/bugs, or an initcall_debug log. Give each of these init and exit functions unique driver-specific names to eliminate the anonymous names. Example 1: (System.map) ffffffff832fc78c t init ffffffff832fc79e t init ffffffff832fc8f8 t init Example 2: (initcall_debug log) calling init+0x0/0x12 @ 1 initcall init+0x0/0x12 returned 0 after 15 usecs calling init+0x0/0x60 @ 1 initcall init+0x0/0x60 returned 0 after 2 usecs calling init+0x0/0x9a @ 1 initcall init+0x0/0x9a returned 0 after 74 usecs Fixes: e126ba9 ("mlx5: Add driver for Mellanox Connect-IB adapters") Signed-off-by: Randy Dunlap <[email protected]> Cc: Eli Cohen <[email protected]> Cc: Saeed Mahameed <[email protected]> Cc: Leon Romanovsky <[email protected]> Cc: [email protected] Reviewed-by: Ira Weiny <[email protected]> Reviewed-by: Leon Romanovsky <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent 7c83d1f commit 2c1e1b9

File tree

1 file changed

+4
-4
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core

1 file changed

+4
-4
lines changed

drivers/net/ethernet/mellanox/mlx5/core/main.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2098,7 +2098,7 @@ static void mlx5_core_verify_params(void)
20982098
}
20992099
}
21002100

2101-
static int __init init(void)
2101+
static int __init mlx5_init(void)
21022102
{
21032103
int err;
21042104

@@ -2133,13 +2133,13 @@ static int __init init(void)
21332133
return err;
21342134
}
21352135

2136-
static void __exit cleanup(void)
2136+
static void __exit mlx5_cleanup(void)
21372137
{
21382138
mlx5e_cleanup();
21392139
mlx5_sf_driver_unregister();
21402140
pci_unregister_driver(&mlx5_core_driver);
21412141
mlx5_unregister_debugfs();
21422142
}
21432143

2144-
module_init(init);
2145-
module_exit(cleanup);
2144+
module_init(mlx5_init);
2145+
module_exit(mlx5_cleanup);

0 commit comments

Comments
 (0)