Skip to content

Commit 291f93c

Browse files
Barry Songgregkh
Barry Song
authored and
gregkh
committed
lib: test_bitmap: add bitmap_print_bitmask/list_to_buf test cases
The added test items cover both cases where bitmap buf of the printed result is greater than and less than 4KB. And it also covers the case where offset for printing is non-zero which will happen when printed buf is larger than one page in sysfs bin_attribute. Reported-by: kernel test robot <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: Barry Song <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 1fae562 commit 291f93c

File tree

1 file changed

+150
-0
lines changed

1 file changed

+150
-0
lines changed

‎lib/test_bitmap.c‎

Lines changed: 150 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
KSTM_MODULE_GLOBALS();
2020

2121
static char pbl_buffer[PAGE_SIZE] __initdata;
22+
static char print_buf[PAGE_SIZE * 2] __initdata;
2223

2324
static const unsigned long exp1[] __initconst = {
2425
BITMAP_FROM_U64(1),
@@ -156,6 +157,20 @@ static bool __init __check_eq_clump8(const char *srcfile, unsigned int line,
156157
return true;
157158
}
158159

160+
static bool __init
161+
__check_eq_str(const char *srcfile, unsigned int line,
162+
const char *exp_str, const char *str,
163+
unsigned int len)
164+
{
165+
bool eq;
166+
167+
eq = strncmp(exp_str, str, len) == 0;
168+
if (!eq)
169+
pr_err("[%s:%u] expected %s, got %s\n", srcfile, line, exp_str, str);
170+
171+
return eq;
172+
}
173+
159174
#define __expect_eq(suffix, ...) \
160175
({ \
161176
int result = 0; \
@@ -173,6 +188,7 @@ static bool __init __check_eq_clump8(const char *srcfile, unsigned int line,
173188
#define expect_eq_pbl(...) __expect_eq(pbl, ##__VA_ARGS__)
174189
#define expect_eq_u32_array(...) __expect_eq(u32_array, ##__VA_ARGS__)
175190
#define expect_eq_clump8(...) __expect_eq(clump8, ##__VA_ARGS__)
191+
#define expect_eq_str(...) __expect_eq(str, ##__VA_ARGS__)
176192

177193
static void __init test_zero_clear(void)
178194
{
@@ -660,6 +676,139 @@ static void __init test_bitmap_cut(void)
660676
}
661677
}
662678

679+
struct test_bitmap_print {
680+
const unsigned long *bitmap;
681+
unsigned long nbits;
682+
const char *mask;
683+
const char *list;
684+
};
685+
686+
static const unsigned long small_bitmap[] __initconst = {
687+
BITMAP_FROM_U64(0x3333333311111111ULL),
688+
};
689+
690+
static const char small_mask[] __initconst = "33333333,11111111\n";
691+
static const char small_list[] __initconst = "0,4,8,12,16,20,24,28,32-33,36-37,40-41,44-45,48-49,52-53,56-57,60-61\n";
692+
693+
static const unsigned long large_bitmap[] __initconst = {
694+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
695+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
696+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
697+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
698+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
699+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
700+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
701+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
702+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
703+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
704+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
705+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
706+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
707+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
708+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
709+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
710+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
711+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
712+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
713+
BITMAP_FROM_U64(0x3333333311111111ULL), BITMAP_FROM_U64(0x3333333311111111ULL),
714+
};
715+
716+
static const char large_mask[] __initconst = "33333333,11111111,33333333,11111111,"
717+
"33333333,11111111,33333333,11111111,"
718+
"33333333,11111111,33333333,11111111,"
719+
"33333333,11111111,33333333,11111111,"
720+
"33333333,11111111,33333333,11111111,"
721+
"33333333,11111111,33333333,11111111,"
722+
"33333333,11111111,33333333,11111111,"
723+
"33333333,11111111,33333333,11111111,"
724+
"33333333,11111111,33333333,11111111,"
725+
"33333333,11111111,33333333,11111111,"
726+
"33333333,11111111,33333333,11111111,"
727+
"33333333,11111111,33333333,11111111,"
728+
"33333333,11111111,33333333,11111111,"
729+
"33333333,11111111,33333333,11111111,"
730+
"33333333,11111111,33333333,11111111,"
731+
"33333333,11111111,33333333,11111111,"
732+
"33333333,11111111,33333333,11111111,"
733+
"33333333,11111111,33333333,11111111,"
734+
"33333333,11111111,33333333,11111111,"
735+
"33333333,11111111,33333333,11111111\n";
736+
737+
static const char large_list[] __initconst = /* more than 4KB */
738+
"0,4,8,12,16,20,24,28,32-33,36-37,40-41,44-45,48-49,52-53,56-57,60-61,64,68,72,76,80,84,88,92,96-97,100-101,104-1"
739+
"05,108-109,112-113,116-117,120-121,124-125,128,132,136,140,144,148,152,156,160-161,164-165,168-169,172-173,176-1"
740+
"77,180-181,184-185,188-189,192,196,200,204,208,212,216,220,224-225,228-229,232-233,236-237,240-241,244-245,248-2"
741+
"49,252-253,256,260,264,268,272,276,280,284,288-289,292-293,296-297,300-301,304-305,308-309,312-313,316-317,320,3"
742+
"24,328,332,336,340,344,348,352-353,356-357,360-361,364-365,368-369,372-373,376-377,380-381,384,388,392,396,400,4"
743+
"04,408,412,416-417,420-421,424-425,428-429,432-433,436-437,440-441,444-445,448,452,456,460,464,468,472,476,480-4"
744+
"81,484-485,488-489,492-493,496-497,500-501,504-505,508-509,512,516,520,524,528,532,536,540,544-545,548-549,552-5"
745+
"53,556-557,560-561,564-565,568-569,572-573,576,580,584,588,592,596,600,604,608-609,612-613,616-617,620-621,624-6"
746+
"25,628-629,632-633,636-637,640,644,648,652,656,660,664,668,672-673,676-677,680-681,684-685,688-689,692-693,696-6"
747+
"97,700-701,704,708,712,716,720,724,728,732,736-737,740-741,744-745,748-749,752-753,756-757,760-761,764-765,768,7"
748+
"72,776,780,784,788,792,796,800-801,804-805,808-809,812-813,816-817,820-821,824-825,828-829,832,836,840,844,848,8"
749+
"52,856,860,864-865,868-869,872-873,876-877,880-881,884-885,888-889,892-893,896,900,904,908,912,916,920,924,928-9"
750+
"29,932-933,936-937,940-941,944-945,948-949,952-953,956-957,960,964,968,972,976,980,984,988,992-993,996-997,1000-"
751+
"1001,1004-1005,1008-1009,1012-1013,1016-1017,1020-1021,1024,1028,1032,1036,1040,1044,1048,1052,1056-1057,1060-10"
752+
"61,1064-1065,1068-1069,1072-1073,1076-1077,1080-1081,1084-1085,1088,1092,1096,1100,1104,1108,1112,1116,1120-1121"
753+
",1124-1125,1128-1129,1132-1133,1136-1137,1140-1141,1144-1145,1148-1149,1152,1156,1160,1164,1168,1172,1176,1180,1"
754+
"184-1185,1188-1189,1192-1193,1196-1197,1200-1201,1204-1205,1208-1209,1212-1213,1216,1220,1224,1228,1232,1236,124"
755+
"0,1244,1248-1249,1252-1253,1256-1257,1260-1261,1264-1265,1268-1269,1272-1273,1276-1277,1280,1284,1288,1292,1296,"
756+
"1300,1304,1308,1312-1313,1316-1317,1320-1321,1324-1325,1328-1329,1332-1333,1336-1337,1340-1341,1344,1348,1352,13"
757+
"56,1360,1364,1368,1372,1376-1377,1380-1381,1384-1385,1388-1389,1392-1393,1396-1397,1400-1401,1404-1405,1408,1412"
758+
",1416,1420,1424,1428,1432,1436,1440-1441,1444-1445,1448-1449,1452-1453,1456-1457,1460-1461,1464-1465,1468-1469,1"
759+
"472,1476,1480,1484,1488,1492,1496,1500,1504-1505,1508-1509,1512-1513,1516-1517,1520-1521,1524-1525,1528-1529,153"
760+
"2-1533,1536,1540,1544,1548,1552,1556,1560,1564,1568-1569,1572-1573,1576-1577,1580-1581,1584-1585,1588-1589,1592-"
761+
"1593,1596-1597,1600,1604,1608,1612,1616,1620,1624,1628,1632-1633,1636-1637,1640-1641,1644-1645,1648-1649,1652-16"
762+
"53,1656-1657,1660-1661,1664,1668,1672,1676,1680,1684,1688,1692,1696-1697,1700-1701,1704-1705,1708-1709,1712-1713"
763+
",1716-1717,1720-1721,1724-1725,1728,1732,1736,1740,1744,1748,1752,1756,1760-1761,1764-1765,1768-1769,1772-1773,1"
764+
"776-1777,1780-1781,1784-1785,1788-1789,1792,1796,1800,1804,1808,1812,1816,1820,1824-1825,1828-1829,1832-1833,183"
765+
"6-1837,1840-1841,1844-1845,1848-1849,1852-1853,1856,1860,1864,1868,1872,1876,1880,1884,1888-1889,1892-1893,1896-"
766+
"1897,1900-1901,1904-1905,1908-1909,1912-1913,1916-1917,1920,1924,1928,1932,1936,1940,1944,1948,1952-1953,1956-19"
767+
"57,1960-1961,1964-1965,1968-1969,1972-1973,1976-1977,1980-1981,1984,1988,1992,1996,2000,2004,2008,2012,2016-2017"
768+
",2020-2021,2024-2025,2028-2029,2032-2033,2036-2037,2040-2041,2044-2045,2048,2052,2056,2060,2064,2068,2072,2076,2"
769+
"080-2081,2084-2085,2088-2089,2092-2093,2096-2097,2100-2101,2104-2105,2108-2109,2112,2116,2120,2124,2128,2132,213"
770+
"6,2140,2144-2145,2148-2149,2152-2153,2156-2157,2160-2161,2164-2165,2168-2169,2172-2173,2176,2180,2184,2188,2192,"
771+
"2196,2200,2204,2208-2209,2212-2213,2216-2217,2220-2221,2224-2225,2228-2229,2232-2233,2236-2237,2240,2244,2248,22"
772+
"52,2256,2260,2264,2268,2272-2273,2276-2277,2280-2281,2284-2285,2288-2289,2292-2293,2296-2297,2300-2301,2304,2308"
773+
",2312,2316,2320,2324,2328,2332,2336-2337,2340-2341,2344-2345,2348-2349,2352-2353,2356-2357,2360-2361,2364-2365,2"
774+
"368,2372,2376,2380,2384,2388,2392,2396,2400-2401,2404-2405,2408-2409,2412-2413,2416-2417,2420-2421,2424-2425,242"
775+
"8-2429,2432,2436,2440,2444,2448,2452,2456,2460,2464-2465,2468-2469,2472-2473,2476-2477,2480-2481,2484-2485,2488-"
776+
"2489,2492-2493,2496,2500,2504,2508,2512,2516,2520,2524,2528-2529,2532-2533,2536-2537,2540-2541,2544-2545,2548-25"
777+
"49,2552-2553,2556-2557\n";
778+
779+
static const struct test_bitmap_print test_print[] __initconst = {
780+
{ small_bitmap, sizeof(small_bitmap) * BITS_PER_BYTE, small_mask, small_list },
781+
{ large_bitmap, sizeof(large_bitmap) * BITS_PER_BYTE, large_mask, large_list },
782+
};
783+
784+
static void __init test_bitmap_print_buf(void)
785+
{
786+
int i;
787+
788+
for (i = 0; i < ARRAY_SIZE(test_print); i++) {
789+
const struct test_bitmap_print *t = &test_print[i];
790+
int n;
791+
792+
n = bitmap_print_bitmask_to_buf(print_buf, t->bitmap, t->nbits,
793+
0, 2 * PAGE_SIZE);
794+
expect_eq_uint(strlen(t->mask) + 1, n);
795+
expect_eq_str(t->mask, print_buf, n);
796+
797+
n = bitmap_print_list_to_buf(print_buf, t->bitmap, t->nbits,
798+
0, 2 * PAGE_SIZE);
799+
expect_eq_uint(strlen(t->list) + 1, n);
800+
expect_eq_str(t->list, print_buf, n);
801+
802+
/* test by non-zero offset */
803+
if (strlen(t->list) > PAGE_SIZE) {
804+
n = bitmap_print_list_to_buf(print_buf, t->bitmap, t->nbits,
805+
PAGE_SIZE, PAGE_SIZE);
806+
expect_eq_uint(strlen(t->list) + 1 - PAGE_SIZE, n);
807+
expect_eq_str(t->list + PAGE_SIZE, print_buf, n);
808+
}
809+
}
810+
}
811+
663812
static void __init selftest(void)
664813
{
665814
test_zero_clear();
@@ -672,6 +821,7 @@ static void __init selftest(void)
672821
test_mem_optimisations();
673822
test_for_each_set_clump8();
674823
test_bitmap_cut();
824+
test_bitmap_print_buf();
675825
}
676826

677827
KSTM_MODULE_LOADERS(test_bitmap);

0 commit comments

Comments
 (0)