netfilter: conntrack: Remove useless assignment statements

luo penghao · ummakynes · commit 284ca7647c67 · 2021-12-16T00:17:40.000+01:00
The old_size assignment here will not be used anymore

The clang_analyzer complains as follows:

Value stored to 'old_size' is never read

Reported-by: Zeal Robot &lt;zealci@zte.com.cn&gt;
Signed-off-by: luo penghao &lt;luo.penghao@zte.com.cn&gt;
Signed-off-by: Pablo Neira Ayuso &lt;pablo@netfilter.org&gt;
diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
@@ -2588,7 +2588,6 @@ int nf_conntrack_hash_resize(unsigned int hashsize)
 			hlist_nulls_add_head_rcu(&h->hnnode, &hash[bucket]);
 		}
 	}
-	old_size = nf_conntrack_htable_size;
 	old_hash = nf_conntrack_hash;
 
 	nf_conntrack_hash = hash;

Original file line number	Diff line number	Diff line change
`@@ -2588,7 +2588,6 @@ int nf_conntrack_hash_resize(unsigned int hashsize)`
`2588`	`2588`	`hlist_nulls_add_head_rcu(&h->hnnode, &hash[bucket]);`
`2589`	`2589`	`}`
`2590`	`2590`	`}`
`2591`		`- old_size = nf_conntrack_htable_size;`
`2592`	`2591`	`old_hash = nf_conntrack_hash;`
`2593`	`2592`
`2594`	`2593`	`nf_conntrack_hash = hash;`