r8169: avoid link-up interrupt issue on RTL8106e if user enables ASPM

hkallweit · davem330 · commit 1ee8856de82f · 2021-06-11T12:54:25.000-07:00
It has been reported that on RTL8106e the link-up interrupt may be
significantly delayed if the user enables ASPM L1. Per default ASPM
is disabled. The change leaves L1 enabled on the PCIe link (thus still
allowing to reach higher package power saving states), but the
NIC won't actively trigger it.

Reported-by: Koba Ko &lt;koba.ko@canonical.com&gt;
Tested-by: Koba Ko &lt;koba.ko@canonical.com&gt;
Signed-off-by: Heiner Kallweit &lt;hkallweit1@gmail.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
@@ -3508,7 +3508,6 @@ static void rtl_hw_start_8106(struct rtl8169_private *tp)
 	rtl_eri_write(tp, 0x1b0, ERIAR_MASK_0011, 0x0000);
 
 	rtl_pcie_state_l2l3_disable(tp);
-	rtl_hw_aspm_clkreq_enable(tp, true);
 }
 
 DECLARE_RTL_COND(rtl_mac_ocp_e00e_cond)

Original file line number	Diff line number	Diff line change
`@@ -3508,7 +3508,6 @@ static void rtl_hw_start_8106(struct rtl8169_private *tp)`
`3508`	`3508`	`rtl_eri_write(tp, 0x1b0, ERIAR_MASK_0011, 0x0000);`
`3509`	`3509`
`3510`	`3510`	`rtl_pcie_state_l2l3_disable(tp);`
`3511`		`- rtl_hw_aspm_clkreq_enable(tp, true);`
`3512`	`3511`	`}`
`3513`	`3512`
`3514`	`3513`	`DECLARE_RTL_COND(rtl_mac_ocp_e00e_cond)`