l2tp: exit_net cleanup check added

vaverin · davem330 · commit 1e7af3b2cdf2 · 2017-11-14T15:45:53.000+09:00
Be sure that l2tp_session_hlist array initialized in net_init hook
was return to initial state.

Signed-off-by: Vasily Averin &lt;vvs@virtuozzo.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
@@ -1833,6 +1833,7 @@ static __net_exit void l2tp_exit_net(struct net *net)
 {
 	struct l2tp_net *pn = l2tp_pernet(net);
 	struct l2tp_tunnel *tunnel = NULL;
+	int hash;
 
 	rcu_read_lock_bh();
 	list_for_each_entry_rcu(tunnel, &pn->l2tp_tunnel_list, list) {
@@ -1842,6 +1843,9 @@ static __net_exit void l2tp_exit_net(struct net *net)
 
 	flush_workqueue(l2tp_wq);
 	rcu_barrier();
+
+	for (hash = 0; hash < L2TP_HASH_SIZE_2; hash++)
+		WARN_ON_ONCE(!hlist_empty(&pn->l2tp_session_hlist[hash]));
 }
 
 static struct pernet_operations l2tp_net_ops = {

Original file line number	Diff line number	Diff line change
`@@ -1833,6 +1833,7 @@ static __net_exit void l2tp_exit_net(struct net *net)`
`1833`	`1833`	`{`
`1834`	`1834`	`struct l2tp_net *pn = l2tp_pernet(net);`
`1835`	`1835`	`struct l2tp_tunnel *tunnel = NULL;`
	`1836`	`+ int hash;`
`1836`	`1837`
`1837`	`1838`	`rcu_read_lock_bh();`
`1838`	`1839`	`list_for_each_entry_rcu(tunnel, &pn->l2tp_tunnel_list, list) {`
`@@ -1842,6 +1843,9 @@ static __net_exit void l2tp_exit_net(struct net *net)`
`1842`	`1843`
`1843`	`1844`	`flush_workqueue(l2tp_wq);`
`1844`	`1845`	`rcu_barrier();`
	`1846`	`+`
	`1847`	`+ for (hash = 0; hash < L2TP_HASH_SIZE_2; hash++)`
	`1848`	`+ WARN_ON_ONCE(!hlist_empty(&pn->l2tp_session_hlist[hash]));`
`1845`	`1849`	`}`
`1846`	`1850`
`1847`	`1851`	`static struct pernet_operations l2tp_net_ops = {`