Skip to content

Commit 1b51f69

Browse files
committed
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
Pull networking fixes from David Miller: "It looks like a decent sized set of fixes, but a lot of these are one liner off-by-one and similar type changes: 1) Fix netlink header pointer to calcular bad attribute offset reported to user. From Pablo Neira Ayuso. 2) Don't double clear PHY interrupts when ->did_interrupt is set, from Heiner Kallweit. 3) Add missing validation of various (devlink, nl802154, fib, etc.) attributes, from Jakub Kicinski. 4) Missing *pos increments in various netfilter seq_next ops, from Vasily Averin. 5) Missing break in of_mdiobus_register() loop, from Dajun Jin. 6) Don't double bump tx_dropped in veth driver, from Jiang Lidong. 7) Work around FMAN erratum A050385, from Madalin Bucur. 8) Make sure ARP header is pulled early enough in bonding driver, from Eric Dumazet. 9) Do a cond_resched() during multicast processing of ipvlan and macvlan, from Mahesh Bandewar. 10) Don't attach cgroups to unrelated sockets when in interrupt context, from Shakeel Butt. 11) Fix tpacket ring state management when encountering unknown GSO types. From Willem de Bruijn. 12) Fix MDIO bus PHY resume by checking mdio_bus_phy_may_suspend() only in the suspend context. From Heiner Kallweit" * git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net: (112 commits) net: systemport: fix index check to avoid an array out of bounds access tc-testing: add ETS scheduler to tdc build configuration net: phy: fix MDIO bus PM PHY resuming net: hns3: clear port base VLAN when unload PF net: hns3: fix RMW issue for VLAN filter switch net: hns3: fix VF VLAN table entries inconsistent issue net: hns3: fix "tc qdisc del" failed issue taprio: Fix sending packets without dequeueing them net: mvmdio: avoid error message for optional IRQ net: dsa: mv88e6xxx: Add missing mask of ATU occupancy register net: memcg: fix lockdep splat in inet_csk_accept() s390/qeth: implement smarter resizing of the RX buffer pool s390/qeth: refactor buffer pool code s390/qeth: use page pointers to manage RX buffer pool seg6: fix SRv6 L2 tunnels to use IANA-assigned protocol number net: dsa: Don't instantiate phylink for CPU/DSA ports unless needed net/packet: tpacket_rcv: do not increment ring index on drop sxgbe: Fix off by one in samsung driver strncpy size arg net: caif: Add lockdep expression to RCU traversal primitive MAINTAINERS: remove Sathya Perla as Emulex NIC maintainer ...
2 parents 807f030 + c036859 commit 1b51f69

File tree

110 files changed

+993
-370
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

110 files changed

+993
-370
lines changed

Documentation/devicetree/bindings/net/fsl-fman.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,13 @@ PROPERTIES
110110
Usage: required
111111
Definition: See soc/fsl/qman.txt and soc/fsl/bman.txt
112112

113+
- fsl,erratum-a050385
114+
Usage: optional
115+
Value type: boolean
116+
Definition: A boolean property. Indicates the presence of the
117+
erratum A050385 which indicates that DMA transactions that are
118+
split can result in a FMan lock.
119+
113120
=============================================================================
114121
FMan MURAM Node
115122

Documentation/networking/devlink/devlink-region.rst

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ example usage
4040
# Delete a snapshot using:
4141
$ devlink region del pci/0000:00:05.0/cr-space snapshot 1
4242
43-
# Trigger (request) a snapshot be taken:
44-
$ devlink region trigger pci/0000:00:05.0/cr-space
45-
4643
# Dump a snapshot:
4744
$ devlink region dump pci/0000:00:05.0/fw-health snapshot 1
4845
0000000000000000 0014 95dc 0014 9514 0035 1670 0034 db30

Documentation/networking/net_failover.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ Overview
88
========
99

1010
The net_failover driver provides an automated failover mechanism via APIs
11-
to create and destroy a failover master netdev and mananges a primary and
11+
to create and destroy a failover master netdev and manages a primary and
1212
standby slave netdevs that get registered via the generic failover
13-
infrastructrure.
13+
infrastructure.
1414

1515
The failover netdev acts a master device and controls 2 slave devices. The
1616
original paravirtual interface is registered as 'standby' slave netdev and
@@ -29,7 +29,7 @@ virtio-net accelerated datapath: STANDBY mode
2929
=============================================
3030

3131
net_failover enables hypervisor controlled accelerated datapath to virtio-net
32-
enabled VMs in a transparent manner with no/minimal guest userspace chanages.
32+
enabled VMs in a transparent manner with no/minimal guest userspace changes.
3333

3434
To support this, the hypervisor needs to enable VIRTIO_NET_F_STANDBY
3535
feature on the virtio-net interface and assign the same MAC address to both

Documentation/networking/rds.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ Socket Interface
159159
set SO_RDS_TRANSPORT on a socket for which the transport has
160160
been previously attached explicitly (by SO_RDS_TRANSPORT) or
161161
implicitly (via bind(2)) will return an error of EOPNOTSUPP.
162-
An attempt to set SO_RDS_TRANSPPORT to RDS_TRANS_NONE will
162+
An attempt to set SO_RDS_TRANSPORT to RDS_TRANS_NONE will
163163
always return EINVAL.
164164

165165
RDMA for RDS

MAINTAINERS

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4073,7 +4073,6 @@ F: drivers/scsi/snic/
40734073
CISCO VIC ETHERNET NIC DRIVER
40744074
M: Christian Benvenuti <[email protected]>
40754075
M: Govindarajulu Varadarajan <[email protected]>
4076-
M: Parvi Kaustubhi <[email protected]>
40774076
S: Supported
40784077
F: drivers/net/ethernet/cisco/enic/
40794078

@@ -4572,7 +4571,7 @@ F: drivers/infiniband/hw/cxgb4/
45724571
F: include/uapi/rdma/cxgb4-abi.h
45734572

45744573
CXGB4VF ETHERNET DRIVER (CXGB4VF)
4575-
M: Casey Leedom <leedom@chelsio.com>
4574+
M: Vishal Kulkarni <vishal@gmail.com>
45764575
45774576
W: http://www.chelsio.com
45784577
S: Supported
@@ -6198,7 +6197,6 @@ S: Supported
61986197
F: drivers/scsi/be2iscsi/
61996198

62006199
Emulex 10Gbps NIC BE2, BE3-R, Lancer, Skyhawk-R DRIVER (be2net)
6201-
M: Sathya Perla <[email protected]>
62026200
M: Ajit Khaparde <[email protected]>
62036201
M: Sriharsha Basavapatna <[email protected]>
62046202
M: Somnath Kotur <[email protected]>

arch/arm64/boot/dts/freescale/fsl-ls1043-post.dtsi

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
};
2121

2222
&fman0 {
23+
fsl,erratum-a050385;
24+
2325
/* these aliases provide the FMan ports mapping */
2426
enet0: ethernet@e0000 {
2527
};

drivers/atm/nicstar.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
#ifdef GENERAL_DEBUG
9292
#define PRINTK(args...) printk(args)
9393
#else
94-
#define PRINTK(args...)
94+
#define PRINTK(args...) do {} while (0)
9595
#endif /* GENERAL_DEBUG */
9696

9797
#ifdef EXTRA_DEBUG

drivers/net/bonding/bond_alb.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,6 @@ struct arp_pkt {
5050
};
5151
#pragma pack()
5252

53-
static inline struct arp_pkt *arp_pkt(const struct sk_buff *skb)
54-
{
55-
return (struct arp_pkt *)skb_network_header(skb);
56-
}
57-
5853
/* Forward declaration */
5954
static void alb_send_learning_packets(struct slave *slave, u8 mac_addr[],
6055
bool strict_match);
@@ -553,10 +548,11 @@ static void rlb_req_update_subnet_clients(struct bonding *bond, __be32 src_ip)
553548
spin_unlock(&bond->mode_lock);
554549
}
555550

556-
static struct slave *rlb_choose_channel(struct sk_buff *skb, struct bonding *bond)
551+
static struct slave *rlb_choose_channel(struct sk_buff *skb,
552+
struct bonding *bond,
553+
const struct arp_pkt *arp)
557554
{
558555
struct alb_bond_info *bond_info = &(BOND_ALB_INFO(bond));
559-
struct arp_pkt *arp = arp_pkt(skb);
560556
struct slave *assigned_slave, *curr_active_slave;
561557
struct rlb_client_info *client_info;
562558
u32 hash_index = 0;
@@ -653,8 +649,12 @@ static struct slave *rlb_choose_channel(struct sk_buff *skb, struct bonding *bon
653649
*/
654650
static struct slave *rlb_arp_xmit(struct sk_buff *skb, struct bonding *bond)
655651
{
656-
struct arp_pkt *arp = arp_pkt(skb);
657652
struct slave *tx_slave = NULL;
653+
struct arp_pkt *arp;
654+
655+
if (!pskb_network_may_pull(skb, sizeof(*arp)))
656+
return NULL;
657+
arp = (struct arp_pkt *)skb_network_header(skb);
658658

659659
/* Don't modify or load balance ARPs that do not originate locally
660660
* (e.g.,arrive via a bridge).
@@ -664,7 +664,7 @@ static struct slave *rlb_arp_xmit(struct sk_buff *skb, struct bonding *bond)
664664

665665
if (arp->op_code == htons(ARPOP_REPLY)) {
666666
/* the arp must be sent on the selected rx channel */
667-
tx_slave = rlb_choose_channel(skb, bond);
667+
tx_slave = rlb_choose_channel(skb, bond, arp);
668668
if (tx_slave)
669669
bond_hw_addr_copy(arp->mac_src, tx_slave->dev->dev_addr,
670670
tx_slave->dev->addr_len);
@@ -676,7 +676,7 @@ static struct slave *rlb_arp_xmit(struct sk_buff *skb, struct bonding *bond)
676676
* When the arp reply is received the entry will be updated
677677
* with the correct unicast address of the client.
678678
*/
679-
tx_slave = rlb_choose_channel(skb, bond);
679+
tx_slave = rlb_choose_channel(skb, bond, arp);
680680

681681
/* The ARP reply packets must be delayed so that
682682
* they can cancel out the influence of the ARP request.

drivers/net/can/dev.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -883,6 +883,7 @@ static const struct nla_policy can_policy[IFLA_CAN_MAX + 1] = {
883883
= { .len = sizeof(struct can_bittiming) },
884884
[IFLA_CAN_DATA_BITTIMING_CONST]
885885
= { .len = sizeof(struct can_bittiming_const) },
886+
[IFLA_CAN_TERMINATION] = { .type = NLA_U16 },
886887
};
887888

888889
static int can_validate(struct nlattr *tb[], struct nlattr *data[],

drivers/net/dsa/mv88e6xxx/chip.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2769,6 +2769,8 @@ static u64 mv88e6xxx_devlink_atu_bin_get(struct mv88e6xxx_chip *chip,
27692769
goto unlock;
27702770
}
27712771

2772+
occupancy &= MV88E6XXX_G2_ATU_STATS_MASK;
2773+
27722774
unlock:
27732775
mv88e6xxx_reg_unlock(chip);
27742776

0 commit comments

Comments
 (0)