Skip to content

Commit 18626d7

Browse files
committed
powerpc/pseries: Limit EPOW reset event warnings
jira LE-1907 Rebuild_History Non-Buildable kernel-3.10.0-514.el7 Rebuild_CHGLOG: - [powerpc] pseries: Limit EPOW reset event warnings (Gustavo Duarte) [1303078] Rebuild_FUZZ: 90.91% commit-author Vipin K Parashar <[email protected]> commit b4af279 Empty-Commit: Cherry-Pick Conflicts during history rebuild. Will be included in final tarball splat. Ref for failed cherry-pick at: ciq/ciq_backports/kernel-3.10.0-514.el7/b4af279a.failed Kernel prints respective warnings about various EPOW events for user information/action after parsing EPOW interrupts. At times below EPOW reset event warning is seen to be flooding kernel log over a period of time. May 25 03:46:34 alp kernel: Non critical power or cooling issue cleared May 25 03:46:52 alp kernel: Non critical power or cooling issue cleared May 25 03:53:48 alp kernel: Non critical power or cooling issue cleared May 25 03:55:46 alp kernel: Non critical power or cooling issue cleared May 25 03:56:34 alp kernel: Non critical power or cooling issue cleared May 25 03:59:04 alp kernel: Non critical power or cooling issue cleared May 25 04:02:01 alp kernel: Non critical power or cooling issue cleared These EPOW reset events are spurious in nature and are triggered by firmware without an actual EPOW event being reset. This patch avoids these multiple EPOW reset warnings by using a counter variable. This variable is incremented every time an EPOW event is reported. Upon receiving a EPOW reset event the same variable is checked to filter out spurious events and decremented accordingly. This patch also improves log messages to better describe EPOW event being reported. Merged adjacent log messages into single one to reduce number of lines printed per event. Signed-off-by: Kamalesh Babulal <[email protected]> Signed-off-by: Vipin K Parashar <[email protected]> Signed-off-by: Michael Ellerman <[email protected]> (cherry picked from commit b4af279) Signed-off-by: Jonathan Maple <[email protected]> # Conflicts: # arch/powerpc/platforms/pseries/ras.c
1 parent acbc87a commit 18626d7

File tree

1 file changed

+64
-0
lines changed

1 file changed

+64
-0
lines changed
Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
powerpc/pseries: Limit EPOW reset event warnings
2+
3+
jira LE-1907
4+
Rebuild_History Non-Buildable kernel-3.10.0-514.el7
5+
Rebuild_CHGLOG: - [powerpc] pseries: Limit EPOW reset event warnings (Gustavo Duarte) [1303078]
6+
Rebuild_FUZZ: 90.91%
7+
commit-author Vipin K Parashar <[email protected]>
8+
commit b4af279a7cba5cc1f665485e8ecdf272f1ba0cc5
9+
Empty-Commit: Cherry-Pick Conflicts during history rebuild.
10+
Will be included in final tarball splat. Ref for failed cherry-pick at:
11+
ciq/ciq_backports/kernel-3.10.0-514.el7/b4af279a.failed
12+
13+
Kernel prints respective warnings about various EPOW events for
14+
user information/action after parsing EPOW interrupts. At times
15+
below EPOW reset event warning is seen to be flooding kernel log
16+
over a period of time.
17+
18+
May 25 03:46:34 alp kernel: Non critical power or cooling issue cleared
19+
May 25 03:46:52 alp kernel: Non critical power or cooling issue cleared
20+
May 25 03:53:48 alp kernel: Non critical power or cooling issue cleared
21+
May 25 03:55:46 alp kernel: Non critical power or cooling issue cleared
22+
May 25 03:56:34 alp kernel: Non critical power or cooling issue cleared
23+
May 25 03:59:04 alp kernel: Non critical power or cooling issue cleared
24+
May 25 04:02:01 alp kernel: Non critical power or cooling issue cleared
25+
26+
These EPOW reset events are spurious in nature and are triggered by
27+
firmware without an actual EPOW event being reset. This patch avoids these
28+
multiple EPOW reset warnings by using a counter variable. This variable
29+
is incremented every time an EPOW event is reported. Upon receiving a EPOW
30+
reset event the same variable is checked to filter out spurious events and
31+
decremented accordingly.
32+
33+
This patch also improves log messages to better describe EPOW event being
34+
reported. Merged adjacent log messages into single one to reduce number of
35+
lines printed per event.
36+
37+
Signed-off-by: Kamalesh Babulal <[email protected]>
38+
Signed-off-by: Vipin K Parashar <[email protected]>
39+
Signed-off-by: Michael Ellerman <[email protected]>
40+
(cherry picked from commit b4af279a7cba5cc1f665485e8ecdf272f1ba0cc5)
41+
Signed-off-by: Jonathan Maple <[email protected]>
42+
43+
# Conflicts:
44+
# arch/powerpc/platforms/pseries/ras.c
45+
diff --cc arch/powerpc/platforms/pseries/ras.c
46+
index 55cbad443500,9a3e27b863ce..000000000000
47+
--- a/arch/powerpc/platforms/pseries/ras.c
48+
+++ b/arch/powerpc/platforms/pseries/ras.c
49+
@@@ -87,8 -90,9 +90,14 @@@ static void handle_system_shutdown(cha
50+
break;
51+
52+
case EPOW_SHUTDOWN_ON_UPS:
53+
++<<<<<<< HEAD
54+
+ pr_emerg("Loss of power reported by firmware, system is "
55+
+ "running on UPS/battery");
56+
++=======
57+
+ pr_emerg("Loss of system power detected. System is running on"
58+
+ " UPS/battery. Check RTAS error log for details\n");
59+
+ orderly_poweroff(true);
60+
++>>>>>>> b4af279a7cba (powerpc/pseries: Limit EPOW reset event warnings)
61+
break;
62+
63+
case EPOW_SHUTDOWN_LOSS_OF_CRITICAL_FUNCTIONS:
64+
* Unmerged path arch/powerpc/platforms/pseries/ras.c

0 commit comments

Comments
 (0)