Skip to content

Commit 15df286

Browse files
fthainhdeller
authored andcommitted
fbdev: Fix logic error in "offb" name match
A regression was reported to me recently whereby /dev/fb0 had disappeared from a PowerBook G3 Series "Wallstreet". The problem shows up when the "video=ofonly" parameter is passed to the kernel, which is what the bootloader does when "no video driver" is selected. The cause of the problem is the "offb" string comparison, which got mangled when it got refactored. Fix it. Cc: [email protected] Fixes: 93604a5 ("fbdev: Handle video= parameter in video/cmdline.c") Reported-and-tested-by: Stan Johnson <[email protected]> Signed-off-by: Finn Thain <[email protected]> Signed-off-by: Helge Deller <[email protected]>
1 parent 3637d34 commit 15df286

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/video/fbdev/core/fb_cmdline.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ int fb_get_options(const char *name, char **option)
4040
bool enabled;
4141

4242
if (name)
43-
is_of = strncmp(name, "offb", 4);
43+
is_of = !strncmp(name, "offb", 4);
4444

4545
enabled = __video_get_options(name, &options, is_of);
4646

0 commit comments

Comments
 (0)