Skip to content

Commit 1145169

Browse files
dstarke-siemensgregkh
authored andcommitted
tty: n_gsm: fix missing mux reset on config change at responder
Currently, only the initiator resets the mux protocol if the user requests new parameters that are incompatible to those of the current connection. The responder also needs to reset the multiplexer if the new parameter set requires this. Otherwise, we end up with an inconsistent parameter set between initiator and responder. Revert the old behavior to inform the peer upon an incompatible parameter set change from the user on the responder side by re-establishing the mux protocol in such case. Fixes: 509067b ("tty: n_gsm: Delete gsm_disconnect when config requester") Cc: [email protected] Signed-off-by: Daniel Starke <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent ce522ba commit 1145169

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/tty/n_gsm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2373,7 +2373,7 @@ static int gsm_config(struct gsm_mux *gsm, struct gsm_config *c)
23732373
* configuration
23742374
*/
23752375

2376-
if (gsm->initiator && (need_close || need_restart)) {
2376+
if (need_close || need_restart) {
23772377
int ret;
23782378

23792379
ret = gsm_disconnect(gsm);

0 commit comments

Comments
 (0)