Skip to content

Commit 0dc987b

Browse files
juhapekkamatt-auld
authored andcommitted
drm/i915/display: Add smem fallback allocation for dpt
Add fallback smem allocation for dpt if stolen memory allocation failed. Signed-off-by: Juha-Pekka Heikkila <[email protected]> Reviewed-by: Matthew Auld <[email protected]> Signed-off-by: Matthew Auld <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent d976521 commit 0dc987b

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

drivers/gpu/drm/i915/display/intel_dpt.c

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
*/
55

66
#include "gem/i915_gem_domain.h"
7+
#include "gem/i915_gem_internal.h"
78
#include "gt/gen8_ppgtt.h"
89

910
#include "i915_drv.h"
@@ -127,8 +128,12 @@ struct i915_vma *intel_dpt_pin(struct i915_address_space *vm)
127128
struct i915_vma *vma;
128129
void __iomem *iomem;
129130
struct i915_gem_ww_ctx ww;
131+
u64 pin_flags = 0;
130132
int err;
131133

134+
if (i915_gem_object_is_stolen(dpt->obj))
135+
pin_flags |= PIN_MAPPABLE;
136+
132137
wakeref = intel_runtime_pm_get(&i915->runtime_pm);
133138
atomic_inc(&i915->gpu_error.pending_fb_pin);
134139

@@ -138,7 +143,7 @@ struct i915_vma *intel_dpt_pin(struct i915_address_space *vm)
138143
continue;
139144

140145
vma = i915_gem_object_ggtt_pin_ww(dpt->obj, &ww, NULL, 0, 4096,
141-
HAS_LMEM(i915) ? 0 : PIN_MAPPABLE);
146+
pin_flags);
142147
if (IS_ERR(vma)) {
143148
err = PTR_ERR(vma);
144149
continue;
@@ -248,10 +253,13 @@ intel_dpt_create(struct intel_framebuffer *fb)
248253

249254
size = round_up(size * sizeof(gen8_pte_t), I915_GTT_PAGE_SIZE);
250255

251-
if (HAS_LMEM(i915))
252-
dpt_obj = i915_gem_object_create_lmem(i915, size, I915_BO_ALLOC_CONTIGUOUS);
253-
else
256+
dpt_obj = i915_gem_object_create_lmem(i915, size, I915_BO_ALLOC_CONTIGUOUS);
257+
if (IS_ERR(dpt_obj) && i915_ggtt_has_aperture(to_gt(i915)->ggtt))
254258
dpt_obj = i915_gem_object_create_stolen(i915, size);
259+
if (IS_ERR(dpt_obj) && !HAS_LMEM(i915)) {
260+
drm_dbg_kms(&i915->drm, "Allocating dpt from smem\n");
261+
dpt_obj = i915_gem_object_create_internal(i915, size);
262+
}
255263
if (IS_ERR(dpt_obj))
256264
return ERR_CAST(dpt_obj);
257265

0 commit comments

Comments
 (0)