Skip to content

Commit 0d1fac6

Browse files
stephan-ghkuba-moo
authored andcommitted
net: wwan: mhi_wwan_mbim: Silence sequence number glitch errors
When using the Qualcomm X55 modem on the ThinkPad X13s, the kernel log is constantly being filled with errors related to a "sequence number glitch", e.g.: [ 1903.284538] sequence number glitch prev=16 curr=0 [ 1913.812205] sequence number glitch prev=50 curr=0 [ 1923.698219] sequence number glitch prev=142 curr=0 [ 2029.248276] sequence number glitch prev=1555 curr=0 [ 2046.333059] sequence number glitch prev=70 curr=0 [ 2076.520067] sequence number glitch prev=272 curr=0 [ 2158.704202] sequence number glitch prev=2655 curr=0 [ 2218.530776] sequence number glitch prev=2349 curr=0 [ 2225.579092] sequence number glitch prev=6 curr=0 Internet connectivity is working fine, so this error seems harmless. It looks like modem does not preserve the sequence number when entering low power state; the amount of errors depends on how actively the modem is being used. A similar issue has also been seen on USB-based MBIM modems [1]. However, in cdc_ncm.c the "sequence number glitch" message is a debug message instead of an error. Apply the same to the mhi_wwan_mbim.c driver to silence these errors when using the modem. [1]: https://lists.freedesktop.org/archives/libmbim-devel/2016-November/000781.html Signed-off-by: Stephan Gerhold <[email protected]> Reviewed-by: Loic Poulain <[email protected]> Acked-by: Manivannan Sadhasivam <[email protected]> Link: https://patch.msgid.link/20250212-mhi-wwan-mbim-sequence-glitch-v1-1-503735977cbd@linaro.org Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 054e61b commit 0d1fac6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/wwan/mhi_wwan_mbim.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ static int mbim_rx_verify_nth16(struct mhi_mbim_context *mbim, struct sk_buff *s
220220
if (mbim->rx_seq + 1 != le16_to_cpu(nth16->wSequence) &&
221221
(mbim->rx_seq || le16_to_cpu(nth16->wSequence)) &&
222222
!(mbim->rx_seq == 0xffff && !le16_to_cpu(nth16->wSequence))) {
223-
net_err_ratelimited("sequence number glitch prev=%d curr=%d\n",
223+
net_dbg_ratelimited("sequence number glitch prev=%d curr=%d\n",
224224
mbim->rx_seq, le16_to_cpu(nth16->wSequence));
225225
}
226226
mbim->rx_seq = le16_to_cpu(nth16->wSequence);

0 commit comments

Comments
 (0)