Skip to content

Commit 0d1c18a

Browse files
Russell King (Oracle)kuba-moo
authored andcommitted
net: stmmac: qcom-ethqos: remove speed_mode_2500() method
qcom-ethqos doesn't need to implement the speed_mode_2500() method as it is only setting priv->plat->phy_interface to 2500BASE-X, which is already a pre-condition for assigning speed_mode_2500 in qcom_ethqos_probe(). So, qcom_ethqos_speed_mode_2500() has no effect. Remove it. Signed-off-by: Russell King (Oracle) <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 4c30093 commit 0d1c18a

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -672,13 +672,6 @@ static int ethqos_configure_sgmii(struct qcom_ethqos *ethqos, int speed)
672672
return val;
673673
}
674674

675-
static void qcom_ethqos_speed_mode_2500(struct net_device *ndev, void *data)
676-
{
677-
struct stmmac_priv *priv = netdev_priv(ndev);
678-
679-
priv->plat->phy_interface = PHY_INTERFACE_MODE_2500BASEX;
680-
}
681-
682675
static int ethqos_configure(struct qcom_ethqos *ethqos, int speed)
683676
{
684677
return ethqos->configure_func(ethqos, speed);
@@ -800,8 +793,6 @@ static int qcom_ethqos_probe(struct platform_device *pdev)
800793
ethqos->configure_func = ethqos_configure_rgmii;
801794
break;
802795
case PHY_INTERFACE_MODE_2500BASEX:
803-
plat_dat->speed_mode_2500 = qcom_ethqos_speed_mode_2500;
804-
fallthrough;
805796
case PHY_INTERFACE_MODE_SGMII:
806797
ethqos->configure_func = ethqos_configure_sgmii;
807798
break;

0 commit comments

Comments
 (0)