Skip to content

Commit 0976b88

Browse files
kuba-moodavem330
authored andcommitted
ethtool: fix null-ptr-deref on ref tracker
dev can be a NULL here, not all requests set require_dev. Fixes: e4b8954 ("netlink: add net device refcount tracker to struct ethnl_req_info") Signed-off-by: Jakub Kicinski <[email protected]> Reviewed-by: Eric Dumazet <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent a9aa5e3 commit 0976b88

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

net/ethtool/netlink.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,10 @@ int ethnl_parse_header_dev_get(struct ethnl_req_info *req_info,
141141
return -EINVAL;
142142
}
143143

144-
req_info->dev = dev;
145-
netdev_tracker_alloc(dev, &req_info->dev_tracker, GFP_KERNEL);
144+
if (dev) {
145+
req_info->dev = dev;
146+
netdev_tracker_alloc(dev, &req_info->dev_tracker, GFP_KERNEL);
147+
}
146148
req_info->flags = flags;
147149
return 0;
148150
}

0 commit comments

Comments
 (0)