Commit 082c3d4
committed
wifi: mac80211: don't return unset power in ieee80211_get_tx_power()
jira LE-1907
cve CVE-2023-52832
Rebuild_History Non-Buildable kernel-4.18.0-553.16.1.el8_10
commit-author Ping-Ke Shih <[email protected]>
commit e160ab8
We can get a UBSAN warning if ieee80211_get_tx_power() returns the
INT_MIN value mac80211 internally uses for "unset power level".
UBSAN: signed-integer-overflow in net/wireless/nl80211.c:3816:5
-2147483648 * 100 cannot be represented in type 'int'
CPU: 0 PID: 20433 Comm: insmod Tainted: G WC OE
Call Trace:
dump_stack+0x74/0x92
ubsan_epilogue+0x9/0x50
handle_overflow+0x8d/0xd0
__ubsan_handle_mul_overflow+0xe/0x10
nl80211_send_iface+0x688/0x6b0 [cfg80211]
[...]
cfg80211_register_wdev+0x78/0xb0 [cfg80211]
cfg80211_netdev_notifier_call+0x200/0x620 [cfg80211]
[...]
ieee80211_if_add+0x60e/0x8f0 [mac80211]
ieee80211_register_hw+0xda5/0x1170 [mac80211]
In this case, simply return an error instead, to indicate
that no data is available.
Cc: Zong-Zhe Yang <[email protected]>
Signed-off-by: Ping-Ke Shih <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Johannes Berg <[email protected]>
(cherry picked from commit e160ab8)
Signed-off-by: Jonathan Maple <[email protected]>1 parent bbf3997 commit 082c3d4
1 file changed
+4
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3105 | 3105 | | |
3106 | 3106 | | |
3107 | 3107 | | |
| 3108 | + | |
| 3109 | + | |
| 3110 | + | |
| 3111 | + | |
3108 | 3112 | | |
3109 | 3113 | | |
3110 | 3114 | | |
| |||
0 commit comments