Skip to content

Commit 05bfd7d

Browse files
Hakon-Buggedavem330
authored andcommitted
rds: Reintroduce statistics counting
In commit 7e3f295 ("rds: don't let RDS shutdown a connection while senders are present"), refilling the receive queue was removed from rds_ib_recv(), along with the increment of s_ib_rx_refill_from_thread. Commit 73ce431 ("RDS: make sure we post recv buffers") re-introduces filling the receive queue from rds_ib_recv(), but does not add the statistics counter. rds_ib_recv() was later renamed to rds_ib_recv_path(). This commit reintroduces the statistics counting of s_ib_rx_refill_from_thread and s_ib_rx_refill_from_cq. Signed-off-by: Håkon Bugge <[email protected]> Reviewed-by: Knut Omang <[email protected]> Reviewed-by: Wei Lin Guay <[email protected]> Reviewed-by: Shamir Rabinovitch <[email protected]> Acked-by: Santosh Shilimkar <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 8ba6092 commit 05bfd7d

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

net/rds/ib_recv.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1015,8 +1015,10 @@ void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic,
10151015
if (rds_ib_ring_empty(&ic->i_recv_ring))
10161016
rds_ib_stats_inc(s_ib_rx_ring_empty);
10171017

1018-
if (rds_ib_ring_low(&ic->i_recv_ring))
1018+
if (rds_ib_ring_low(&ic->i_recv_ring)) {
10191019
rds_ib_recv_refill(conn, 0, GFP_NOWAIT);
1020+
rds_ib_stats_inc(s_ib_rx_refill_from_cq);
1021+
}
10201022
}
10211023

10221024
int rds_ib_recv_path(struct rds_conn_path *cp)
@@ -1029,6 +1031,7 @@ int rds_ib_recv_path(struct rds_conn_path *cp)
10291031
if (rds_conn_up(conn)) {
10301032
rds_ib_attempt_ack(ic);
10311033
rds_ib_recv_refill(conn, 0, GFP_KERNEL);
1034+
rds_ib_stats_inc(s_ib_rx_refill_from_thread);
10321035
}
10331036

10341037
return ret;

0 commit comments

Comments
 (0)