style: added verbose coding of in_place catalog filtering

fix: bypassed a pycsep error where sometimes CartesianGrid2D are not imported with a proper dh

Author: pabloitu

floatcsep/experiment.py

@@ -350,7 +350,7 @@ def catalog(self) -> CSEPCatalog:
             )
 
             if self.region:
-                catalog.filter_spatial(region=self.region)
+                catalog.filter_spatial(region=self.region, in_place=True)
                 catalog.region = None
             catalog.write_json(self._catpath)
 
@@ -408,7 +408,7 @@ def get_test_cat(self, tstring: str = None) -> CSEPCatalog:
              f'magnitude >= {self.mag_min}',
              f'magnitude < {self.mag_max}'], in_place=False)
         if self.region:
-            sub_cat.filter_spatial(region=self.region)
+            sub_cat.filter_spatial(region=self.region, in_place=True)
 
         return sub_cat
 
@@ -437,7 +437,7 @@ def set_test_cat(self, tstring: str) -> None:
                  f'magnitude >= {self.mag_min}',
                  f'magnitude < {self.mag_max}'], in_place=False)
             if self.region:
-                sub_cat.filter_spatial(region=self.region)
+                sub_cat.filter_spatial(region=self.region, in_place=True)
             sub_cat.write_json(filename=testcat_name)
         else:
             log.debug(f'Using stored test sub-catalog from {testcat_name}')

floatcsep/utils.py

@@ -220,8 +220,13 @@ def read_region_cfg(region_config, **kwargs):
                 except ValueError:
                     data = numpy.array([re.split(r'\s+|,', i.strip()) for i in
                                         parsed_region[1:]], dtype=float)
-                region = CartesianGrid2D.from_origins(data, name=region_data,
-                                                      magnitudes=magnitudes)
+                dh1 = scipy.stats.mode(np.diff(np.unique(data[:, 0]))).mode
+                dh2 = scipy.stats.mode(np.diff(np.unique(data[:, 1]))).mode
+                dh = np.min([dh1, dh2])
+                region = CartesianGrid2D.from_origins(data,
+                                                      name=region_data,
+                                                      magnitudes=magnitudes,
+                                                      dh=dh)
                 region_config.update({'path': region_data})
         else:
             region_data['magnitudes'] = magnitudes