Move UpgradePath to crate.qa.tests

Author: mkleen

src/crate/qa/tests.py

@@ -28,6 +28,13 @@
     '/usr/lib/java-1.8.0',
 ) + tuple(glob('/Library/Java/JavaVirtualMachines/jdk*1.8*/Contents/Home'))
 
+class UpgradePath(NamedTuple):
+    from_version: str
+    to_version: str
+
+    def __repr__(self):
+        return f'{self.from_version} -> {self.to_version}'
+
 
 def prepare_env(java_home_candidates: Iterable[str]) -> dict:
     for candidate in filter(os.path.exists, java_home_candidates):

tests/bwc/test_recovery.py

@@ -5,8 +5,7 @@
 import random
 from random import sample
 
-from crate.qa.tests import NodeProvider, insert_data
-from bwc.test_rolling_upgrade import UpgradePath
+from crate.qa.tests import NodeProvider, insert_data, UpgradePath
 
 
 class RecoveryTest(NodeProvider, unittest.TestCase):

tests/bwc/test_rolling_upgrade.py

@@ -1,16 +1,6 @@
 import unittest
-from typing import NamedTuple
 from crate.client import connect
-from crate.qa.tests import NodeProvider, insert_data, wait_for_active_shards
-
-
-class UpgradePath(NamedTuple):
-    from_version: str
-    to_version: str
-
-    def __repr__(self):
-        return f'{self.from_version} -> {self.to_version}'
-
+from crate.qa.tests import NodeProvider, insert_data, wait_for_active_shards, UpgradePath
 
 ROLLING_UPGRADES = (
     # 4.0.0 -> 4.0.1 -> 4.0.2 don't support rolling upgrades due to a bug