P1206R7 Conversions from ranges to containers #5280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mick235711
suggested changes
Feb 10, 2022
Mick235711
suggested changes
Feb 10, 2022
jensmaurer
force-pushed
the
motions-2022-02-lwg-5
branch
from
aab5bcd to
ddb2fc2
Compare
JohelEGP
suggested changes
Feb 10, 2022
There was a problem hiding this comment.
#5280 (comment) says
The incoming paper uses "is" for the new text. Further, we gravitate towards "shall" being used for diagnosable requirements on user code, which this is not. Not changing.
Here I suggest to change back "is" from the paper that were changed to "shall be" during its transcription. Along with one from the surrounding diff context that shows its inconsistent application.
jensmaurer
force-pushed
the
motions-2022-02-lwg-5
branch
from
8cd3b52 to
aba6417
Compare
tkoeppe
force-pushed
the
motions-2022-02-lwg-5
branch
from
aba6417 to
5768ce4
Compare
- Fix misnamed constructor in [multiset.cons] - Fix garbled constructor in [stack.defn] - Fix bad pack expansion "std::forward<Args...>(args)..."
tkoeppe
force-pushed
the
motions-2022-02-lwg-5
branch
from
5768ce4 to
6d4a94f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5264
Fixes cplusplus/papers#145