Skip to content

P2372R3 Fixing locale handling in chrono formatters #5005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2021
Merged

P2372R3 Fixing locale handling in chrono formatters #5005

merged 1 commit into from
Oct 18, 2021

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer added this to the post-2021-10 milestone Oct 6, 2021
@jensmaurer jensmaurer force-pushed the motions-2021-10-lwg-2 branch from d975fee to 8aa8cd7 Compare October 6, 2021 14:40
JohelEGP
JohelEGP suggested changes Oct 6, 2021
View reviewed changes
@jensmaurer jensmaurer force-pushed the motions-2021-10-lwg-2 branch from b641037 to 14a3b85 Compare October 8, 2021 15:11
timsong-cpp
timsong-cpp reviewed Oct 16, 2021
View reviewed changes
@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Oct 16, 2021
@jensmaurer jensmaurer force-pushed the motions-2021-10-lwg-2 branch from 1b6a649 to 42bcbf0 Compare October 16, 2021 11:19
@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Oct 16, 2021
burblebee
burblebee requested changes Oct 16, 2021
View reviewed changes
Copy link
Contributor

@burblebee burblebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than 2 issues I had with the paper, just the "C" needs to be \tcoded (as already mentioned by timsong-cpp).

burblebee
burblebee approved these changes Oct 16, 2021
View reviewed changes
Copy link
Contributor

@burblebee burblebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"C" has been fixed, but issues with wording remain.

@jensmaurer @tkoeppe
P2372R3 Fixing locale handling in chrono formatters
582ec50 
In [time.zone.zonedtime.nonmembers], remove the separate
"Returns" item now that have "Effects: Equivalent to: return ..."
@tkoeppe tkoeppe force-pushed the motions-2021-10-lwg-2 branch from 42bcbf0 to 582ec50 Compare October 18, 2021 22:37
@tkoeppe tkoeppe merged commit 1203f29 into main Oct 18, 2021
@jensmaurer jensmaurer deleted the motions-2021-10-lwg-2 branch February 9, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe left review comments

@timsong-cpp timsong-cpp timsong-cpp left review comments

@JohelEGP JohelEGP JohelEGP requested changes

@burblebee burblebee burblebee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2021-10
Development

Successfully merging this pull request may close these issues.

[2021-10 LWG Motion 2] P2372R3 Fixing locale handling in chrono formatters P2372 Fixing locale handling in chrono formatters
5 participants
@jensmaurer @tkoeppe @burblebee @timsong-cpp @JohelEGP