-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat!: block stm integration #25334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat!: block stm integration #25334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generic interface generic btree generic cachekv generic transient store support ObjStore changelog Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> object store key Apply review suggestions fix merge conflict fix snapshot revert dependers prefix store support object store (#236) Problem: snapshot for object store is not skipped (#585) resolve
fix and add test
…) (#24604) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex | Interchain Labs <[email protected]>
Co-authored-by: Alex | Interchain Labs <[email protected]>
Co-authored-by: Alex | Interchain Labs <[email protected]>
Co-authored-by: Alex | Interchain Labs <[email protected]>
…24619) (#24620) Co-authored-by: Tyler <[email protected]>
…24626) Co-authored-by: FT <[email protected]>
Co-authored-by: Alex | Interchain Labs <[email protected]>
…backport #24629) (#24631) Co-authored-by: Alex | Interchain Labs <[email protected]>
…ackport #24635) (#24637) Co-authored-by: VolodymyrBg <[email protected]>
…kport #24636) (#24640) Co-authored-by: GarmashAlex <[email protected]>
…4642) Co-authored-by: kilavvy <[email protected]>
Co-authored-by: GarmashAlex <[email protected]>
…#24650) (#24651) Co-authored-by: VolodymyrBg <[email protected]>
…#24652) Co-authored-by: kilavvy <[email protected]>
…ackport #24654) (#24656) Co-authored-by: FT <[email protected]>
Co-authored-by: Maxim Evtush <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initial comments. got like 50% through
swift1337
approved these changes
Oct 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @technicallyty that ideally the RunTx interface should be as concise as possible, otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:CLI
C:Confix
Issues and PR related to Confix
C:Simulations
C:Store
C:x/auth
C:x/bank
C:x/circuit
C:x/gov
C:x/nft
C:x/protocolpool
Type: Build
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate block stm into the SDK (baseapp).
Blockstm Integration
This is the final PR in the SDK which will integrate block stm into the application.
It includes changes to baseapp as well as the bank module. The baseapp changes allow a user to set a block stm executor. The default executor is the existing
deliverTXfunction, while theBlockSTMExecutorcan be used to enable parallel execution.The Bank module also includes changes which utilize the object store to store transient data and an end blocker which accumulates the data. This is required in order to avoid bank transfers writing to the same key/value pair in every transaction (which would force re-execution of each transaction and defeat the purpose of parallel execution).
It also includes
Contextchanges which allow caching of values and indices of transactions to be passed around during execution in order to enable in memory caching during execution.