Follow up of 4870 - Ignore 404 on thanos_objstore_bucket_operation_failures_total only when fetching the markers
#4874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
follow up 4870 Signed-off-by: Alan Protasio <[email protected]>
alanprot
force-pushed
the
followup/4870
branch
from
ac44d3e to
717caa5
Compare
1 task
yeya24
approved these changes
Sep 20, 2022
Contributor
yeya24
left a comment
yeya24
left a comment
There was a problem hiding this comment.
Cool. This is exactly what I am working on tonight. But you are so fast :)
alvinlin123
approved these changes
Sep 20, 2022
Contributor
|
You two need to have some work life balance :) Thanks for powwow through it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Just a follow up of #4870
On that PR we were not counting 404s on all buckets operations. This PR only ignores 404s when fetching the visitor marker as this error is expected there.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]