Skip to content

Fix tiny issue of doc in RandomRatioBased #4867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Fix tiny issue of doc in RandomRatioBased #4867

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0acdee8
Fix tiny issue of doc in RandomRatioBased
alvinlin123 Sep 15, 2022
c368e55
I was wrong, the methods didn't implement interface
alvinlin123 Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/tracing/sampler/sampling.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type RandomRatioBased struct {
fraction float64
}

// NewRandomRatioBased crea
// NewRandomRatioBased creates a sampler based on random number.
// fraction parameter should be between 0 and 1 where:
// fraction >= 1 it will always sample
// fraction <= 0 it will never sample
Expand Down