From adefd9e4331abf48aba7e360270c1419c24ea6fc Mon Sep 17 00:00:00 2001 From: Alvin Lin Date: Thu, 17 Feb 2022 12:43:35 -0800 Subject: [PATCH 1/4] Prepare release 1.12.0 Signed-off-by: Alvin Lin --- CHANGELOG.md | 8 +++++--- pkg/ruler/manager_metrics.go | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a9d172a2468..6e98da92e6d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,14 +2,16 @@ ## master / unreleased +## 1.12.0 in pgoress + * [CHANGE] Changed default for `-ingester.min-ready-duration` from 1 minute to 15 seconds. #4539 -* [CHANGE] query-frontend: Do not print anything in the logs of `query-frontend` if a in-progress query has been canceled (context canceled). #4562 +* [CHANGE] query-frontend: Do not print anything in the logs of `query-frontend` if a in-progress query has been canceled (context canceled)i to avoid spam. #4562 * [CHANGE] Compactor block deletion mark migration, needed when upgrading from v1.7, is now disabled by default. #4597 * [CHANGE] The `status_code` label on gRPC client metrics has changed from '200' and '500' to '2xx', '5xx', '4xx', 'cancel' or 'error'. 4601 * [CHANGE] Memberlist: changed probe interval from `1s` to `5s` and probe timeout from `500ms` to `2s`. #4601 * [FEATURE] Add shuffle sharding grouper and planner within compactor to allow further work towards parallelizing compaction #4624 * [ENHANCEMENT] Update Go version to 1.17.5. #4602 #4604 -* [ENHANCEMENT] Keep track of discarded samples due to relabel configuration in `cortex_discarded_samples_total`. #4503 +* [ENHANCEMENT] Keep track of discarded samples due to bad relabel configuration in `cortex_discarded_samples_total`. #4503 * [ENHANCEMENT] Ruler: Add `-ruler.disable-rule-group-label` to disable the `rule_group` label on exported metrics. #4571 * [ENHANCEMENT] Query federation: improve performance in MergeQueryable by memoizing labels. #4502 * [ENHANCEMENT] Added new ring related config `-ingester.readiness-check-ring-health` when enabled the readiness probe will succeed only after all instances are ACTIVE and healthy in the ring, this is enabled by default. #4539 @@ -21,7 +23,7 @@ * [ENHANCEMENT] Optimise memberlist receive path when used as a backing store for rings with a large number of members. #4601 * [ENHANCEMENT] Add length and limit to labelNameTooLongError and labelValueTooLongError #4595 * [BUGFIX] AlertManager: remove stale template files. #4495 -* [BUGFIX] Distributor: fix bug in query-exemplar where some results would get dropped. #4582 +* [BUGFIX] Distributor: fix bug in query-exemplar where some results would get dropped. #4583 * [BUGFIX] Update Thanos dependency: compactor tracing support, azure blocks storage memory fix. #4585 * [BUGFIX] Set appropriate `Content-Type` header for /services endpoint, which previously hard-coded `text/plain`. #4596 * [BUGFIX] Querier: Disable query scheduler SRV DNS lookup, which removes noisy log messages about "failed DNS SRV record lookup". #4601 diff --git a/pkg/ruler/manager_metrics.go b/pkg/ruler/manager_metrics.go index 79cd26f7632..9df71513840 100644 --- a/pkg/ruler/manager_metrics.go +++ b/pkg/ruler/manager_metrics.go @@ -74,7 +74,7 @@ func NewManagerMetrics(disableRuleGroupLabel bool) *ManagerMetrics { GroupInterval: prometheus.NewDesc( "cortex_prometheus_rule_group_interval_seconds", "The interval of a rule group.", - commonLabels, + commonLabels,`` nil, ), GroupLastEvalTime: prometheus.NewDesc( From 7dbf20e5904d843c70418a9c5413080c46fe46c6 Mon Sep 17 00:00:00 2001 From: Alvin Lin Date: Thu, 17 Feb 2022 13:05:26 -0800 Subject: [PATCH 2/4] Prepare release 1.12.0 Signed-off-by: Alvin Lin --- RELEASE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASE.md b/RELEASE.md index 45c066eebd9..333f31059b3 100644 --- a/RELEASE.md +++ b/RELEASE.md @@ -27,7 +27,7 @@ Our goal is to provide a new minor release every 6 weeks. This is a new process | v1.9.0 | 2021-04-29 | Goutham Veeramachaneni (@gouthamve) | | v1.10.0 | 2021-06-25 | Bryan Boreham (@bboreham) | | v1.11.0 | 2021-08-06 | Marco Pracucci (@pracucci) | -| v1.12.0 | 2021-09-17 | | +| v1.12.0 | 2022-02-17 | Alvin Lin (@alvinlin123) | ## Release shepherd responsibilities From fa00228638ca99fa73084b86072e37a5ce520656 Mon Sep 17 00:00:00 2001 From: Alvin Lin Date: Thu, 17 Feb 2022 13:14:28 -0800 Subject: [PATCH 3/4] Revert unintended change Signed-off-by: Alvin Lin --- pkg/ruler/manager_metrics.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/ruler/manager_metrics.go b/pkg/ruler/manager_metrics.go index 9df71513840..79cd26f7632 100644 --- a/pkg/ruler/manager_metrics.go +++ b/pkg/ruler/manager_metrics.go @@ -74,7 +74,7 @@ func NewManagerMetrics(disableRuleGroupLabel bool) *ManagerMetrics { GroupInterval: prometheus.NewDesc( "cortex_prometheus_rule_group_interval_seconds", "The interval of a rule group.", - commonLabels,`` + commonLabels, nil, ), GroupLastEvalTime: prometheus.NewDesc( From a77153b4f60da536477588313ddd5c76e97b1a5b Mon Sep 17 00:00:00 2001 From: Alvin Lin Date: Thu, 17 Feb 2022 13:16:54 -0800 Subject: [PATCH 4/4] Fix typo Signed-off-by: Alvin Lin --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6e98da92e6d..005523be3d6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ ## 1.12.0 in pgoress * [CHANGE] Changed default for `-ingester.min-ready-duration` from 1 minute to 15 seconds. #4539 -* [CHANGE] query-frontend: Do not print anything in the logs of `query-frontend` if a in-progress query has been canceled (context canceled)i to avoid spam. #4562 +* [CHANGE] query-frontend: Do not print anything in the logs of `query-frontend` if a in-progress query has been canceled (context canceled) to avoid spam. #4562 * [CHANGE] Compactor block deletion mark migration, needed when upgrading from v1.7, is now disabled by default. #4597 * [CHANGE] The `status_code` label on gRPC client metrics has changed from '200' and '500' to '2xx', '5xx', '4xx', 'cancel' or 'error'. 4601 * [CHANGE] Memberlist: changed probe interval from `1s` to `5s` and probe timeout from `500ms` to `2s`. #4601