Update k8s deps to latest version #3935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something downstream seemed to need this but I don't know anymore. This doesn't seem to hurt though, so lets use what Prometheus uses (2 patch releases ahead). Updating it manually downgrades Thanos. ``` ➜ go get -u k8s.io/[email protected] go: downloading k8s.io/client-go v1.5.2 go get: downgraded github.com/thanos-io/thanos v0.13.1-0.20210226164558-03dace0a1aa1 => v0.11.0 go get: downgraded k8s.io/client-go v12.0.0+incompatible => v0.20.4 ``` Yes, at this point, I have no clue what is happening. Signed-off-by: Goutham Veeramachaneni <[email protected]>
pracucci
approved these changes
Mar 11, 2021
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
No file changed in vendor/?
Contributor
Author
Surprisingly no. |
Contributor
|
It is not a surprise, I don't think cortex does use them an therefore those files should not be in vendor. |
roystchiang
pushed a commit
to roystchiang/cortex
that referenced
this pull request
Apr 6, 2022
Something downstream seemed to need this but I don't know anymore. This doesn't seem to hurt though, so lets use what Prometheus uses (2 patch releases ahead). Updating it manually downgrades Thanos. ``` ➜ go get -u k8s.io/[email protected] go: downloading k8s.io/client-go v1.5.2 go get: downgraded github.com/thanos-io/thanos v0.13.1-0.20210226164558-03dace0a1aa1 => v0.11.0 go get: downgraded k8s.io/client-go v12.0.0+incompatible => v0.20.4 ``` Yes, at this point, I have no clue what is happening. Signed-off-by: Goutham Veeramachaneni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something downstream seemed to need this but I don't know anymore. This
doesn't seem to hurt though, so lets use what Prometheus uses (2 patch
releases ahead).
Updating it manually downgrades Thanos.
Yes, at this point, I have no clue what is happening.