Skip to content

Commit e36c332

Browse files
committed
Add missing parameter to compact.NewGroup
Signed-off-by: Alvin Lin <[email protected]>
1 parent 3760f2b commit e36c332

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

pkg/compactor/shuffle_sharding_grouper.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import (
1313
"github.com/pkg/errors"
1414
"github.com/prometheus/client_golang/prometheus"
1515
"github.com/prometheus/client_golang/prometheus/promauto"
16-
"github.com/prometheus/prometheus/pkg/labels"
16+
"github.com/prometheus/prometheus/model/labels"
1717
"github.com/thanos-io/thanos/pkg/block/metadata"
1818
"github.com/thanos-io/thanos/pkg/compact"
1919
"github.com/thanos-io/thanos/pkg/objstore"
@@ -26,6 +26,7 @@ type ShuffleShardingGrouper struct {
2626
enableVerticalCompaction bool
2727
reg prometheus.Registerer
2828
blocksMarkedForDeletion prometheus.Counter
29+
blocksMarkedForNoCompact prometheus.Counter
2930
garbageCollectedBlocks prometheus.Counter
3031
hashFunc metadata.HashFunc
3132
compactions *prometheus.CounterVec
@@ -43,6 +44,7 @@ func NewShuffleShardingGrouper(
4344
enableVerticalCompaction bool,
4445
reg prometheus.Registerer,
4546
blocksMarkedForDeletion prometheus.Counter,
47+
blocksMarkedForNoCompact prometheus.Counter,
4648
garbageCollectedBlocks prometheus.Counter,
4749
hashFunc metadata.HashFunc,
4850
compactorCfg Config,
@@ -58,6 +60,7 @@ func NewShuffleShardingGrouper(
5860
enableVerticalCompaction: enableVerticalCompaction,
5961
reg: reg,
6062
blocksMarkedForDeletion: blocksMarkedForDeletion,
63+
blocksMarkedForNoCompact: blocksMarkedForNoCompact,
6164
garbageCollectedBlocks: garbageCollectedBlocks,
6265
hashFunc: hashFunc,
6366
// Metrics are copied from Thanos DefaultGrouper constructor
@@ -135,6 +138,7 @@ func (g *ShuffleShardingGrouper) Groups(blocks map[ulid.ULID]*metadata.Meta) (re
135138
g.verticalCompactions.WithLabelValues(groupKey),
136139
g.garbageCollectedBlocks,
137140
g.blocksMarkedForDeletion,
141+
g.blocksMarkedForNoCompact,
138142
g.hashFunc,
139143
)
140144
if err != nil {

0 commit comments

Comments
 (0)