Skip to content

Commit d0aa4d2

Browse files
committed
fix integration test
Signed-off-by: Ben Ye <[email protected]>
1 parent 491c4c6 commit d0aa4d2

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

integration/e2ecortex/client.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,9 @@ func (c *Client) RemoteRead(matchers []*labels.Matcher, start, end time.Time, st
167167
Start: startMs,
168168
End: endMs,
169169
})
170+
if err != nil {
171+
return nil, err
172+
}
170173

171174
req := &prompb.ReadRequest{
172175
Queries: []*prompb.Query{q},
@@ -184,6 +187,9 @@ func (c *Client) RemoteRead(matchers []*labels.Matcher, start, end time.Time, st
184187
defer cancel()
185188

186189
httpReq, err := http.NewRequestWithContext(httpReqCtx, "POST", "http://"+c.querierAddress+"/prometheus/api/v1/read", bytes.NewReader(compressed))
190+
if err != nil {
191+
return nil, err
192+
}
187193
httpReq.Header.Set("X-Scope-OrgID", "user-1")
188194
httpReq.Header.Add("Content-Encoding", "snappy")
189195
httpReq.Header.Add("Accept-Encoding", "snappy")

integration/query_frontend_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -323,9 +323,9 @@ func runQueryFrontendTest(t *testing.T, cfg queryFrontendTestConfig) {
323323

324324
// No need to repeat the test on remote read for each user.
325325
if userID == 0 && cfg.remoteReadEnabled {
326-
start := time.Unix(1595846748, 806*1e6)
327-
end := time.Unix(1595846750, 806*1e6)
328-
res, err := c.RemoteRead([]*labels.Matcher{labels.MustNewMatcher(labels.MatchEqual, "__name__", "series_1")}, start, end, time.Second)
326+
start := now.Add(-1 * time.Hour)
327+
end := now.Add(1 * time.Hour)
328+
res, err := c.RemoteRead([]*labels.Matcher{labels.MustNewMatcher(labels.MatchEqual, labels.MetricName, "series_1")}, start, end, time.Second)
329329
require.NoError(t, err)
330330
require.True(t, len(res.Results) > 0)
331331
require.True(t, len(res.Results[0].Timeseries) > 0)

0 commit comments

Comments
 (0)