Skip to content

Commit 74b72dd

Browse files
committed
Fix ruler tests.
Signed-off-by: Peter Štibraný <[email protected]>
1 parent f122817 commit 74b72dd

File tree

3 files changed

+36
-2
lines changed

3 files changed

+36
-2
lines changed

pkg/ruler/api.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import (
1818
"github.com/prometheus/prometheus/model/labels"
1919
"github.com/prometheus/prometheus/model/rulefmt"
2020
"github.com/weaveworks/common/user"
21-
"gopkg.in/yaml.v2"
21+
"gopkg.in/yaml.v3"
2222

2323
"github.com/cortexproject/cortex/pkg/cortexpb"
2424
"github.com/cortexproject/cortex/pkg/ruler/rulespb"

pkg/ruler/mapper.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import (
1010
"github.com/go-kit/log/level"
1111
"github.com/prometheus/prometheus/model/rulefmt"
1212
"github.com/spf13/afero"
13-
"gopkg.in/yaml.v2"
13+
"gopkg.in/yaml.v3"
1414
)
1515

1616
// mapper is designed to enusre the provided rule sets are identical

pkg/ruler/mapper_test.go

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -395,3 +395,37 @@ func sliceContains(t *testing.T, find string, in []string) bool {
395395

396396
return false
397397
}
398+
399+
func TestYamlFormatting(t *testing.T) {
400+
l := log.NewLogfmtLogger(os.Stdout)
401+
l = level.NewFilter(l, level.AllowInfo())
402+
setupRuleSets()
403+
404+
m := &mapper{
405+
Path: "/rules",
406+
FS: afero.NewMemMapFs(),
407+
logger: l,
408+
}
409+
410+
updated, files, err := m.MapRules(testUser, initialRuleSet)
411+
require.True(t, updated)
412+
require.Len(t, files, 1)
413+
require.Equal(t, fileOnePath, files[0])
414+
require.NoError(t, err)
415+
416+
data, err := afero.ReadFile(m.FS, fileOnePath)
417+
require.NoError(t, err)
418+
419+
expected := `groups:
420+
- name: rulegroup_two
421+
rules:
422+
- record: example_rule
423+
expr: example_expr
424+
- name: rulegroup_one
425+
rules:
426+
- record: example_rule
427+
expr: example_expr
428+
`
429+
430+
require.Equal(t, expected, string(data))
431+
}

0 commit comments

Comments
 (0)