Skip to content

Commit 5915489

Browse files
author
Tyler Reid
committed
update log message for ruler query metrics
Signed-off-by: Tyler Reid <[email protected]>
1 parent db2966c commit 5915489

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

pkg/ruler/compat.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,11 @@ func RecordAndReportRuleQueryMetrics(qf rules.QueryFunc, queryTime prometheus.Co
177177

178178
// Log ruler query stats.
179179
logMessage := append([]interface{}{
180-
"msg", "ruler query stats",
180+
"msg", "query stats",
181+
"component", "ruler",
181182
"cortex_ruler_query_seconds_total", querySeconds,
182-
}, qs)
183+
"query", qs,
184+
})
183185
level.Info(util_log.WithContext(ctx, logger)).Log(logMessage...)
184186
}()
185187

pkg/ruler/compat_test.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -243,19 +243,14 @@ func TestMetricsQueryFuncErrors(t *testing.T) {
243243
}
244244

245245
func TestRecordAndReportRuleQueryMetrics(t *testing.T) {
246-
queries := prometheus.NewCounter(prometheus.CounterOpts{})
247-
failures := prometheus.NewCounter(prometheus.CounterOpts{})
248246
queryTime := prometheus.NewCounterVec(prometheus.CounterOpts{}, []string{"user"})
249247

250248
mockFunc := func(ctx context.Context, q string, t time.Time) (promql.Vector, error) {
251249
time.Sleep(1 * time.Second)
252250
return promql.Vector{}, nil
253251
}
254-
qf := RecordAndReportRuleQueryMetrics(MetricsQueryFunc(mockFunc, queries, failures), queryTime.WithLabelValues("userID"), log.NewNopLogger())
255-
252+
qf := RecordAndReportRuleQueryMetrics(mockFunc, queryTime.WithLabelValues("userID"), log.NewNopLogger())
256253
_, _ = qf(context.Background(), "test", time.Now())
257254

258-
require.Equal(t, 1, int(testutil.ToFloat64(queries)))
259-
require.Equal(t, 0, int(testutil.ToFloat64(failures)))
260255
require.GreaterOrEqual(t, testutil.ToFloat64(queryTime.WithLabelValues("userID")), float64(1))
261256
}

0 commit comments

Comments
 (0)