Review feedback - move and rename

Author: bboreham

pkg/chunk/aws/aws_autoscaling.go

@@ -49,7 +49,7 @@ func newAWSAutoscale(cfg DynamoDBConfig, callManager callManager) (*awsAutoscale
 	}, nil
 }
 
-func (a *awsAutoscale) CreateTable(ctx context.Context, desc chunk.TableDesc) error {
+func (a *awsAutoscale) PostCreateTable(ctx context.Context, desc chunk.TableDesc) error {
 	if desc.WriteScale.Enabled {
 		return a.enableAutoScaling(ctx, desc)
 	}

pkg/chunk/aws/dynamodb_table_client.go

@@ -17,7 +17,7 @@ import (
 
 // Pluggable auto-scaler implementation
 type autoscale interface {
-	CreateTable(ctx context.Context, desc chunk.TableDesc) error
+	PostCreateTable(ctx context.Context, desc chunk.TableDesc) error
 	// This whole interface is very similar to chunk.TableClient, but
 	// DescribeTable needs to mutate desc
 	DescribeTable(ctx context.Context, desc *chunk.TableDesc) error
@@ -165,7 +165,7 @@ func (d dynamoTableClient) CreateTable(ctx context.Context, desc chunk.TableDesc
 	}
 
 	if d.autoscale != nil {
-		err := d.autoscale.CreateTable(ctx, desc)
+		err := d.autoscale.PostCreateTable(ctx, desc)
 		if err != nil {
 			return err
 		}

pkg/chunk/aws/metrics_autoscaling.go

@@ -36,7 +36,20 @@ type metricsData struct {
 	usageRates        map[string]float64
 }
 
-func (m *metricsData) CreateTable(ctx context.Context, desc chunk.TableDesc) error {
+func newMetrics(cfg DynamoDBConfig) (*metricsData, error) {
+	client, err := promApi.NewClient(promApi.Config{Address: cfg.MetricsURL})
+	if err != nil {
+		return nil, err
+	}
+	return &metricsData{
+		promAPI:           promV1.NewAPI(client),
+		queueLengthTarget: cfg.MetricsTargetQueueLen,
+		scaleUpFactor:     cfg.MetricsScaleUpFactor,
+		tableLastUpdated:  make(map[string]time.Time),
+	}, nil
+}
+
+func (m *metricsData) PostCreateTable(ctx context.Context, desc chunk.TableDesc) error {
 	return nil
 }
 
@@ -129,19 +142,6 @@ func (m *metricsData) scaleUpWrite(current chunk.TableDesc, expected *chunk.Tabl
 	}
 }
 
-func newMetrics(cfg DynamoDBConfig) (*metricsData, error) {
-	client, err := promApi.NewClient(promApi.Config{Address: cfg.MetricsURL})
-	if err != nil {
-		return nil, err
-	}
-	return &metricsData{
-		promAPI:           promV1.NewAPI(client),
-		queueLengthTarget: cfg.MetricsTargetQueueLen,
-		scaleUpFactor:     cfg.MetricsScaleUpFactor,
-		tableLastUpdated:  make(map[string]time.Time),
-	}, nil
-}
-
 func (m *metricsData) update(ctx context.Context) error {
 	if m.promLastQuery.After(mtime.Now().Add(-cachePromDataFor)) {
 		return nil