defer even on error

alanprot · alanprot · commit 3ed0ccdc645a · 2025-06-11T10:56:29.000-07:00
Signed-off-by: alanprot &lt;alanprot@gmail.com&gt;
diff --git a/pkg/cortexpb/codec.go b/pkg/cortexpb/codec.go
@@ -45,7 +45,7 @@ func (c *cortexCodec) Unmarshal(data mem.BufferSlice, v any) error {
 	err := proto.Unmarshal(buf.ReadOnlyData(), vv)
 
 	if err != nil {
-		buf.Free()
+		defer buf.Free()
 		return err
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ func (c *cortexCodec) Unmarshal(data mem.BufferSlice, v any) error {`
`45`	`45`	`err := proto.Unmarshal(buf.ReadOnlyData(), vv)`
`46`	`46`
`47`	`47`	`if err != nil {`
`48`		`- buf.Free()`
	`48`	`+ defer buf.Free()`
`49`	`49`	`return err`
`50`	`50`	`}`
`51`	`51`