Skip to content

Commit 20bf2cf

Browse files
cboggsbboreham
authored andcommitted
Re-try addition of configurable trace sampling strategy (#709)
* Use new configurable trace sampling and update vendoring to enable the same.
1 parent 74ec287 commit 20bf2cf

File tree

11 files changed

+50
-25
lines changed

11 files changed

+50
-25
lines changed

Gopkg.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/distributor/main.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,7 @@ func main() {
5454
util.InitLogger(logLevel.AllowedLevel)
5555

5656
// Setting the environment variable JAEGER_AGENT_HOST enables tracing
57-
jaegerAgentHost := os.Getenv("JAEGER_AGENT_HOST")
58-
trace := tracing.New(jaegerAgentHost, "distributor")
57+
trace := tracing.NewFromEnv("distributor")
5958
defer trace.Close()
6059

6160
r, err := ring.New(ringConfig)

cmd/ingester/main.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import (
1212

1313
"github.com/weaveworks/common/middleware"
1414
"github.com/weaveworks/common/server"
15+
"github.com/weaveworks/common/tracing"
1516
"github.com/weaveworks/cortex/pkg/chunk"
1617
"github.com/weaveworks/cortex/pkg/chunk/storage"
1718
"github.com/weaveworks/cortex/pkg/ingester"
@@ -26,6 +27,7 @@ func main() {
2627
GRPCMiddleware: []grpc.UnaryServerInterceptor{
2728
middleware.ServerUserHeaderInterceptor,
2829
},
30+
ExcludeRequestInLog: true,
2931
}
3032
chunkStoreConfig chunk.StoreConfig
3133
schemaConfig chunk.SchemaConfig
@@ -35,6 +37,11 @@ func main() {
3537
eventSampleRate int
3638
maxStreams uint
3739
)
40+
41+
// Setting the environment variable JAEGER_AGENT_HOST enables tracing
42+
trace := tracing.NewFromEnv("ingester")
43+
defer trace.Close()
44+
3845
// Ingester needs to know our gRPC listen port.
3946
ingesterConfig.ListenPort = &serverConfig.GRPCListenPort
4047
util.RegisterFlags(&serverConfig, &chunkStoreConfig, &storageConfig,

cmd/lite/main.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,7 @@ func main() {
5959
flag.Parse()
6060

6161
// Setting the environment variable JAEGER_AGENT_HOST enables tracing
62-
jaegerAgentHost := os.Getenv("JAEGER_AGENT_HOST")
63-
trace := tracing.New(jaegerAgentHost, "lite")
62+
trace := tracing.NewFromEnv("ingester")
6463
defer trace.Close()
6564

6665
util.InitLogger(logLevel.AllowedLevel)

cmd/querier/main.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ func main() {
4646
flag.Parse()
4747

4848
// Setting the environment variable JAEGER_AGENT_HOST enables tracing
49-
jaegerAgentHost := os.Getenv("JAEGER_AGENT_HOST")
50-
trace := tracing.New(jaegerAgentHost, "querier")
49+
trace := tracing.NewFromEnv("querier")
5150
defer trace.Close()
5251

5352
util.InitLogger(logLevel.AllowedLevel)

cmd/ruler/main.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@ func main() {
3838
)
3939

4040
// Setting the environment variable JAEGER_AGENT_HOST enables tracing
41-
jaegerAgentHost := os.Getenv("JAEGER_AGENT_HOST")
42-
trace := tracing.New(jaegerAgentHost, "ruler")
41+
trace := tracing.NewFromEnv("ruler")
4342
defer trace.Close()
4443

4544
util.RegisterFlags(&serverConfig, &ringConfig, &distributorConfig,

vendor/github.com/weaveworks/common/logging/logging.go

Lines changed: 2 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/weaveworks/common/middleware/grpc_logging.go

Lines changed: 11 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/weaveworks/common/middleware/logging.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/weaveworks/common/server/server.go

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)