refactor: remove version callback, pass params

Author: muthukrishnan24

cmd/callback.go

@@ -19,12 +19,6 @@ const (
 	HookDir = ".commitlint/hooks"
 )
 
-// VersionCallback is the version command callback
-var VersionCallback = func() error {
-	fmt.Println("commitlint")
-	return nil
-}
-
 func initCallback(ctx *cli.Context) (retErr error) {
 	// get user home dir
 	homeDir, err := os.UserHomeDir()

cmd/cmd.go

@@ -2,11 +2,16 @@
 package cmd
 
 import (
+	"fmt"
+
 	"github.com/urfave/cli/v2"
 )
 
+var verTmpl = `commitlint version %s - built from %s on %s
+`
+
 // New returns commitlint cli.App
-func New() *cli.App {
+func New(versionNo, commitHash, builtTime string) *cli.App {
 	createCmd := &cli.Command{
 		Name:  "create",
 		Usage: "create commitlint config, hooks files",
@@ -69,7 +74,8 @@ func New() *cli.App {
 		Name:  "version",
 		Usage: "prints commitlint version",
 		Action: func(c *cli.Context) error {
-			return VersionCallback()
+			fmt.Printf(verTmpl, versionNo, commitHash, builtTime)
+			return nil
 		},
 	}
 

main.go

@@ -15,16 +15,8 @@ var (
 	BuildTime = ""
 )
 
-var verTmpl = `commitlint %s-%s %s
-`
-
 func main() {
-	cmd.VersionCallback = func() error {
-		fmt.Printf(verTmpl, Version, Commit, BuildTime)
-		return nil
-	}
-
-	app := cmd.New()
+	app := cmd.New(Version, Commit, BuildTime)
 	err := app.Run(os.Args)
 	if err != nil {
 		fmt.Println("Error: ", err)