Skip to content

Commit 03ca336

Browse files
committed
fix: ♻️ change url path for compare and merge apis
1 parent 1b7a2c1 commit 03ca336

File tree

6 files changed

+53
-53
lines changed

6 files changed

+53
-53
lines changed

lib/stack/branch/compare.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { get } from '../../entity'
66
*/
77
export function Compare (http, data = {}) {
88
this.stackHeaders = data.stackHeaders
9-
this.urlPath = `/stacks/branches/compare`
9+
this.urlPath = `/stacks/branches_compare`
1010

1111
/**
1212
* @description List of content types and global fields that exist in only one branch or are different between the two branches.
@@ -23,7 +23,7 @@ export function Compare (http, data = {}) {
2323
*
2424
*/
2525
this.all = async (params = {}) => {
26-
return await get(http, this.urlPath, params, data)
26+
return get(http, this.urlPath, params, data)
2727
}
2828

2929
/**
@@ -47,7 +47,7 @@ export function Compare (http, data = {}) {
4747
url = `${url}/${params.uid}`
4848
delete params.uid
4949
}
50-
return await get(http, url, params, data)
50+
return get(http, url, params, data)
5151
}
5252

5353
/**
@@ -71,7 +71,7 @@ export function Compare (http, data = {}) {
7171
url = `${url}/${params.uid}`
7272
delete params.uid
7373
}
74-
return await get(http, url, params, data)
74+
return get(http, url, params, data)
7575
}
7676

7777
return this

lib/stack/branch/index.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -113,19 +113,19 @@ export function Branch (http, data = {}) {
113113
* @example
114114
* import * as contentstack from '@contentstack/management'
115115
* const client = contentstack.client()
116-
*
116+
*
117117
* const params = {
118118
* base_branch: "main",
119119
* compare_branch: "dev",
120120
* default_merge_strategy: "merge_prefer_base",
121-
* merge_comment: "Merging dev into main",
121+
* merge_comment: "Merging dev into main",
122122
* no_revert: true,
123123
* }
124124
* const mergeObj = {
125-
* item_merge_strategies: [
125+
* item_merge_strategies: [
126126
* {
127-
* uid: "global_field_uid",
128-
* type: "global_field",
127+
* uid: "global_field_uid",
128+
* type: "global_field",
129129
* merge_strategy: "merge_prefer_base"
130130
* }
131131
* ],
@@ -134,32 +134,32 @@ export function Branch (http, data = {}) {
134134
* client.stack({ api_key: 'api_key'}).branch().merge(mergeObj, params)
135135
*/
136136
this.merge = async (mergeObj, params) => {
137-
const url = '/stacks/branches/merge';
138-
const header = {
139-
headers: { ...cloneDeep(this.stackHeaders)},
137+
const url = '/stacks/branches_merge'
138+
const header = {
139+
headers: { ...cloneDeep(this.stackHeaders) },
140140
params: params
141141
}
142142
try {
143-
const response = await http.post(url, mergeObj, header);
144-
if (response.data) return response.data;
143+
const response = await http.post(url, mergeObj, header)
144+
if (response.data) return response.data
145145
else throw error(response)
146146
} catch (e) {
147-
throw error(e);
147+
throw error(e)
148148
}
149149
}
150150

151151
/**
152152
* @description Merge Queue provides list of all recent merge jobs in a Stack.
153153
* @memberof Branch
154154
* @func mergeQueue
155-
* @returns {MergeQueue} Instance of MergeQueue
155+
* @returns {MergeQueue} Instance of MergeQueue
156156
*
157157
* @example
158158
* import * as contentstack from '@contentstack/management'
159159
* const client = contentstack.client()
160160
*
161161
* client.stack({ api_key: 'api_key'}).branch().mergeQueue()
162-
*
162+
*
163163
*/
164164
this.mergeQueue = (uid) => {
165165
const mergeData = { stackHeaders: this.stackHeaders, uid }
@@ -174,4 +174,4 @@ export function BranchCollection (http, data) {
174174
return obj.map((branchData) => {
175175
return new Branch(http, { branch: branchData, stackHeaders: data.stackHeaders })
176176
})
177-
}
177+
}

lib/stack/branch/mergeQueue.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { get } from '../../entity'
22

33
export function MergeQueue (http, data = {}) {
44
this.stackHeaders = data.stackHeaders
5-
this.urlPath = `/stacks/branches/merge-queue`
5+
this.urlPath = `/stacks/branches_queue`
66

77
if (data.uid) {
88
/**
@@ -21,7 +21,7 @@ export function MergeQueue (http, data = {}) {
2121
*/
2222
this.fetch = async () => {
2323
const url = `${this.urlPath}/${data.uid}`
24-
return await get(http, url, {}, data)
24+
return get(http, url, {}, data)
2525
}
2626
} else {
2727
/**
@@ -39,9 +39,9 @@ export function MergeQueue (http, data = {}) {
3939
*
4040
*/
4141
this.find = async (params = {}) => {
42-
return await get(http, this.urlPath, params, data)
42+
return get(http, this.urlPath, params, data)
4343
}
4444
}
4545

4646
return this
47-
}
47+
}

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@contentstack/management",
3-
"version": "1.7.0",
3+
"version": "1.8.0",
44
"description": "The Content Management API is used to manage the content of your Contentstack account",
55
"main": "./dist/node/contentstack-management.js",
66
"browser": "./dist/web/contentstack-management.js",

test/unit/branch-test.js

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,18 @@ import { expect } from 'chai'
33
import { describe, it } from 'mocha'
44
import MockAdapter from 'axios-mock-adapter'
55
import { Branch, BranchCollection } from '../../lib/stack/branch'
6-
import {
7-
branchCompareAllMock,
8-
branchCompareContentTypeMock,
9-
branchCompareGlobalFieldMock,
6+
import {
7+
branchCompareAllMock,
8+
branchCompareContentTypeMock,
9+
branchCompareGlobalFieldMock,
1010
branchMergeAllMock,
1111
branchMergeQueueFindMock,
1212
branchMergeQueueFetchMock,
13-
branchMock,
14-
checkSystemFields,
15-
noticeMock,
16-
stackHeadersMock,
17-
systemUidMock
13+
branchMock,
14+
checkSystemFields,
15+
noticeMock,
16+
stackHeadersMock,
17+
systemUidMock
1818
} from './mock/objects'
1919

2020
describe('Contentstack Branch test', () => {
@@ -168,12 +168,12 @@ describe('Contentstack Branch test', () => {
168168

169169
it('Branch compare all test', done => {
170170
var mock = new MockAdapter(axios)
171-
mock.onGet('/stacks/branches/compare', { params: { base_branch: 'UID', compare_branch:'dev', skip:0, limit:100}}).reply(200, branchCompareAllMock)
171+
mock.onGet('/stacks/branches_compare', { params: { base_branch: 'UID', compare_branch: 'dev', skip: 0, limit: 100 } }).reply(200, branchCompareAllMock)
172172
makeBranch({
173173
branch: {
174174
...systemUidMock
175175
},
176-
stackHeaders: { ...stackHeadersMock, authtoken: 'authtoken'}
176+
stackHeaders: { ...stackHeadersMock, authtoken: 'authtoken' }
177177
})
178178
.compare('dev')
179179
.all({ skip: 0, limit: 100 })
@@ -189,12 +189,12 @@ describe('Contentstack Branch test', () => {
189189

190190
it('Branch compare content types test', done => {
191191
var mock = new MockAdapter(axios)
192-
mock.onGet('/stacks/branches/compare/content_types', { params: { base_branch: 'UID', compare_branch:'dev', skip:0, limit:100}}).reply(200, branchCompareContentTypeMock)
192+
mock.onGet('/stacks/branches_compare/content_types', { params: { base_branch: 'UID', compare_branch: 'dev', skip: 0, limit: 100 } }).reply(200, branchCompareContentTypeMock)
193193
makeBranch({
194194
branch: {
195195
...systemUidMock
196196
},
197-
stackHeaders: { ...stackHeadersMock, authtoken: 'authtoken'}
197+
stackHeaders: { ...stackHeadersMock, authtoken: 'authtoken' }
198198
})
199199
.compare('dev')
200200
.contentTypes({ skip: 0, limit: 100 })
@@ -210,12 +210,12 @@ describe('Contentstack Branch test', () => {
210210

211211
it('Branch compare global fields test', done => {
212212
var mock = new MockAdapter(axios)
213-
mock.onGet('/stacks/branches/compare/global_fields', { params: { base_branch: 'UID', compare_branch:'dev', skip:0, limit:100 }}).reply(200, branchCompareGlobalFieldMock)
213+
mock.onGet('/stacks/branches_compare/global_fields', { params: { base_branch: 'UID', compare_branch: 'dev', skip: 0, limit: 100 } }).reply(200, branchCompareGlobalFieldMock)
214214
makeBranch({
215215
branch: {
216216
...systemUidMock
217217
},
218-
stackHeaders: { ...stackHeadersMock, authtoken: 'authtoken'}
218+
stackHeaders: { ...stackHeadersMock, authtoken: 'authtoken' }
219219
})
220220
.compare('dev')
221221
.globalFields({ skip: 0, limit: 100 })
@@ -232,23 +232,23 @@ describe('Contentstack Branch test', () => {
232232
it('Branch Merge All test', done => {
233233
var mock = new MockAdapter(axios)
234234
const params = {
235-
base_branch: "main",
236-
compare_branch: "dev",
237-
default_merge_strategy: "merge_prefer_base",
238-
merge_comment: "Merging dev into main",
239-
no_revert: true,
235+
base_branch: 'main',
236+
compare_branch: 'dev',
237+
default_merge_strategy: 'merge_prefer_base',
238+
merge_comment: 'Merging dev into main',
239+
no_revert: true
240240
}
241241
const mergeObj = {
242-
item_merge_strategies: [
242+
item_merge_strategies: [
243243
{
244-
uid: "global_field_uid",
245-
type: "global_field",
246-
merge_strategy: "merge_prefer_base"
244+
uid: 'global_field_uid',
245+
type: 'global_field',
246+
merge_strategy: 'merge_prefer_base'
247247
}
248-
],
248+
]
249249
}
250-
mock.onPost('/stacks/branches/merge').reply(200, branchMergeAllMock)
251-
makeBranch({ stackHeaders: { ...stackHeadersMock, authtoken: 'authtoken'} })
250+
mock.onPost('/stacks/branches_merge').reply(200, branchMergeAllMock)
251+
makeBranch({ stackHeaders: { ...stackHeadersMock, authtoken: 'authtoken' } })
252252
.merge(mergeObj, params)
253253
.then((response) => {
254254
checkBranch(response)
@@ -261,7 +261,7 @@ describe('Contentstack Branch test', () => {
261261

262262
it('Branch MergeQueue find test', done => {
263263
var mock = new MockAdapter(axios)
264-
mock.onGet('/stacks/branches/merge-queue').reply(200, branchMergeQueueFindMock)
264+
mock.onGet('/stacks/branches_queue').reply(200, branchMergeQueueFindMock)
265265
makeBranch()
266266
.mergeQueue()
267267
.find()
@@ -276,7 +276,7 @@ describe('Contentstack Branch test', () => {
276276

277277
it('Branch MergeQueue fetch test', done => {
278278
var mock = new MockAdapter(axios)
279-
mock.onGet('/stacks/branches/merge-queue/UID').reply(200, branchMergeQueueFetchMock)
279+
mock.onGet('/stacks/branches_queue/UID').reply(200, branchMergeQueueFetchMock)
280280
makeBranch()
281281
.mergeQueue('UID')
282282
.fetch()

0 commit comments

Comments
 (0)