Shut up staticcheck SA5011

The "o == nil" check was confusing staticcheck into thinking it might be nil
even _after_ the Fatalf (apparently it doesn't recognize that that terminates).

Instead, simplify, drop that extra condition, and if we ever got a nil, we
are going to crash.

*shrug*, less test code to maintain in the future.

Signed-off-by: Miloslav Trmač <[email protected]>

Author: mtrmac

common/pkg/manifests/manifests_test.go

@@ -105,7 +105,7 @@ func TestAddInstance(t *testing.T) {
 			t.Fatalf("adding an instance without platform info failed in %s: %v", version, err)
 		}
 		o, err := list.findOCIv1(manifestDigest)
-		if o == nil || err != nil {
+		if err != nil {
 			t.Fatalf("adding an instance failed in %s: %v", version, err)
 		}
 		if o.Platform != nil {