Skip to content
This repository was archived by the owner on Mar 16, 2021. It is now read-only.

Commit cf5747f

Browse files
authored
Merge pull request #6 from krishchow/podChanges
Pod Info changes
2 parents 4f3017e + 432a49d commit cf5747f

File tree

7 files changed

+202
-149
lines changed

7 files changed

+202
-149
lines changed

cmd/cmd.go

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ var (
3434
nodeID = ""
3535
protocol = ""
3636
listen = ""
37-
basePath = ""
3837
//endpoint = "unix://csi/csi.sock"
3938
)
4039

@@ -46,12 +45,11 @@ var driverCmd = &cobra.Command{
4645
RunE: func(c *cobra.Command, args []string) error {
4746
return driver(args)
4847
},
49-
Version: Version,
5048
}
5149

5250
func init() {
53-
if driverCmd.Version == "" {
54-
driverCmd.Version = "dev"
51+
if Version == "" {
52+
Version = "dev"
5553
}
5654

5755
viper.AutomaticEnv()
@@ -63,9 +61,8 @@ func init() {
6361
driverCmd.PersistentFlags().StringVarP(&identity, "identity", "i", identity, "identity of this COSI CSI driver")
6462
//driverCmd.PersistentFlags().StringVarP(&endpoint, "endpoint", "e", endpoint, "endpoint at which COSI CSI driver is listening")
6563
driverCmd.PersistentFlags().StringVarP(&nodeID, "node-id", "n", nodeID, "identity of the node in which COSI CSI driver is running")
66-
driverCmd.PersistentFlags().StringVarP(&listen, "listen", "l", nodeID, "address of the listening socket for the node server")
67-
driverCmd.PersistentFlags().StringVarP(&protocol, "protocol", "p", nodeID, "must be one of tcp, tcp4, tcp6, unix, unixpacket")
68-
driverCmd.PersistentFlags().StringVarP(&basePath, "basepath", "p", nodeID, "the base path for the CSI driver")
64+
driverCmd.PersistentFlags().StringVarP(&listen, "listen", "l", listen, "address of the listening socket for the node server")
65+
driverCmd.PersistentFlags().StringVarP(&protocol, "protocol", "p", protocol, "must be one of tcp, tcp4, tcp6, unix, unixpacket")
6966

7067
driverCmd.PersistentFlags().MarkHidden("alsologtostderr")
7168
driverCmd.PersistentFlags().MarkHidden("log_backtrace_at")

cmd/driver.go

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ limitations under the License.
1717
package cmd
1818

1919
import (
20-
"net"
20+
"github.com/container-object-storage-interface/ephemeral-csi-driver/pkg/controller"
2121
"os"
2222

2323
cs "github.com/container-object-storage-interface/api/clientset/typed/objectstorage.k8s.io/v1alpha1"
24-
"github.com/container-storage-interface/spec/lib/go/csi"
2524
"github.com/golang/glog"
26-
"google.golang.org/grpc"
25+
csicommon "github.com/kubernetes-csi/drivers/pkg/csi-common"
26+
"k8s.io/client-go/kubernetes"
2727
"k8s.io/client-go/rest"
2828
"k8s.io/klog"
2929

@@ -48,23 +48,14 @@ func driver(args []string) error {
4848
config := &rest.Config{}
4949

5050
client := cs.NewForConfigOrDie(config)
51+
kube := kubernetes.NewForConfigOrDie(config)
5152

52-
node.Initalize(basePath)
53-
node := node.NewNodeServer(identity, nodeID, *client)
54-
if err != nil {
55-
return err
56-
}
53+
nodeServer := node.NewNodeServer(identity, nodeID, *client, kube)
54+
controllerServer, err := controller.NewControllerServer(identity, nodeID)
5755

58-
srv := grpc.NewServer()
59-
csi.RegisterNodeServer(srv, node)
60-
csi.RegisterIdentityServer(srv, idServer)
61-
l, err := net.Listen(protocol, listen)
62-
if err != nil {
63-
klog.Fatalf("could not create listener: %v", err)
64-
}
65-
if err = srv.Serve(l); err != nil {
66-
klog.Fatalf("%v", err)
67-
}
56+
s := csicommon.NewNonBlockingGRPCServer()
57+
s.Start(listen, idServer, controllerServer, nodeServer)
58+
s.Wait()
6859

6960
return nil
7061
}

go.mod

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,9 @@ require (
1010
github.com/go-openapi/spec v0.19.9 // indirect
1111
github.com/go-openapi/swag v0.19.9 // indirect
1212
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
13-
github.com/golang/protobuf v1.4.2 // indirect
1413
github.com/google/gofuzz v1.2.0 // indirect
14+
github.com/kubernetes-csi/csi-lib-utils v0.8.1 // indirect
15+
github.com/kubernetes-csi/drivers v1.0.2
1516
github.com/magiconair/properties v1.8.4 // indirect
1617
github.com/mailru/easyjson v0.7.6 // indirect
1718
github.com/mitchellh/mapstructure v1.3.3 // indirect
@@ -29,7 +30,7 @@ require (
2930
google.golang.org/genproto v0.0.0-20201002142447-3860012362da // indirect
3031
google.golang.org/grpc v1.32.0
3132
gopkg.in/ini.v1 v1.61.0 // indirect
32-
k8s.io/api v0.19.2
33+
k8s.io/api v0.19.2
3334
k8s.io/apimachinery v0.19.2
3435
k8s.io/client-go v0.19.2
3536
k8s.io/klog v1.0.0

0 commit comments

Comments
 (0)