Skip to content

Commit 8c86e6f

Browse files
jpastoorAlexander Obuhovich
authored andcommitted
Renamed Api::api() parameter $return_as_json to $return_as_array (#134)
Renamed `Api::api()` method `$return_as_json` parameter to `$return_as_array`
1 parent 829724f commit 8c86e6f

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
2121
- Minimal supported PHP version changed from 5.2 to 5.3 by [@chobie].
2222
- The `Api::getPriorties` renamed into `Api::getPriorities` by [@josevh].
2323
- Remove trailing slash from endpoint url by [@Procta].
24-
- Added local cache to getResolutions [@jpastoor].
24+
- Added local cache to getResolutions by [@jpastoor].
25+
- Renamed Api::api() parameter $return_as_json to $return_as_array by [@jpastoor].
2526

2627
### Removed
2728
...
@@ -35,7 +36,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
3536
- Fixed PHP deprecation notice, when creating issue attachments via `CurlClient` on PHP 5.5+ by [@DerMika].
3637
- The `Api::getRoles` call was always retuning an error by [@aik099].
3738
- Attempt to make a `DELETE` API call using `CurlClient` wasn't working by [@aik099].
38-
- Clearing local caches (statuses, priorities, fields and resolutions) on endpoint change [@jpastoor].
39+
- Clearing local caches (statuses, priorities, fields and resolutions) on endpoint change by [@jpastoor].
3940

4041
## [1.0.0] - 2014-07-27
4142
### Added

src/Jira/Api.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -701,20 +701,20 @@ public function createRemotelink(
701701
/**
702702
* Send request to specified host.
703703
*
704-
* @param string $method Request method.
705-
* @param string $url URL.
706-
* @param array|string $data Data.
707-
* @param boolean $return_as_json Return results as JSON.
708-
* @param boolean $is_file Is file-related request.
709-
* @param boolean $debug Debug this request.
704+
* @param string $method Request method.
705+
* @param string $url URL.
706+
* @param array|string $data Data.
707+
* @param boolean $return_as_array Return results as associative array.
708+
* @param boolean $is_file Is file-related request.
709+
* @param boolean $debug Debug this request.
710710
*
711711
* @return array|Result|false
712712
*/
713713
public function api(
714714
$method = self::REQUEST_GET,
715715
$url,
716716
$data = array(),
717-
$return_as_json = false,
717+
$return_as_array = false,
718718
$is_file = false,
719719
$debug = false
720720
) {
@@ -743,7 +743,7 @@ public function api(
743743
}
744744
}
745745

746-
if ( $return_as_json ) {
746+
if ( $return_as_array ) {
747747
return $json;
748748
}
749749
else {

0 commit comments

Comments
 (0)