Moved endpoint trailing slash check to setEndpoint and wrote unittest

Author: jpastoor

src/Jira/Api.php

@@ -72,9 +72,6 @@ public function __construct(
         AuthenticationInterface $authentication,
         ClientInterface $client = null
     ) {
-        //Regular expression to remove trailing slash
-        $endpoint = preg_replace('{/$}', '', $endpoint);
-        
         $this->setEndPoint($endpoint);
         $this->authentication = $authentication;
 
@@ -109,6 +106,9 @@ public function setEndPoint($url)
     {
         $this->fields = array();
 
+        //Regular expression to remove trailing slash
+        $url = rtrim($url, '/');
+
         $this->endpoint = $url;
     }
 

tests/Jira/ApiTest.php

@@ -0,0 +1,23 @@
+<?php
+
+namespace Tests\chobie\Jira;
+
+use chobie\Jira\Api;
+use chobie\Jira\Api\Authentication\Anonymous;
+
+/**
+ * Class ApiTest
+ *
+ * @package Tests\chobie\Jira
+ */
+class ApiTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * Tests that any trailing slash in the endpoint url is removed before being stored in the object state
+     */
+    public function testSetEndpointTrailingSlash()
+    {
+        $api = new Api('https://test.test/', new Anonymous(), null);
+        $this->assertEquals('https://test.test', $api->getEndpoint());
+    }
+}