refactor(google): constant for hello account

Author: thekaveman

compiler_admin/commands/reset_password.py

@@ -1,7 +1,7 @@
 from argparse import Namespace
 
 from compiler_admin.commands import RESULT_SUCCESS, RESULT_FAILURE
-from compiler_admin.services.google import CallGAMCommand, user_account_name, user_exists
+from compiler_admin.services.google import USER_HELLO, CallGAMCommand, user_account_name, user_exists
 
 
 def reset_password(args: Namespace) -> int:
@@ -29,7 +29,7 @@ def reset_password(args: Namespace) -> int:
 
     notify = getattr(args, "notify", None)
     if notify:
-        command += ("notify", notify, "from", "[email protected]")
+        command += ("notify", notify, "from", USER_HELLO)
 
     print(f"User exists, resetting password: {account}")
 

compiler_admin/services/google.py

@@ -38,6 +38,9 @@ def user_account_name(username: str) -> str:
 # Archive account
 USER_ARCHIVE = user_account_name("archive")
 
+# Hello account
+USER_HELLO = user_account_name("hello")
+
 # Groups
 GROUP_PARTNERS = user_account_name("partners")
 GROUP_STAFF = user_account_name("staff")

tests/commands/test_reset_password.py

@@ -3,6 +3,7 @@
 
 from compiler_admin.commands import RESULT_FAILURE, RESULT_SUCCESS
 from compiler_admin.commands.reset_password import reset_password, __name__ as MODULE
+from compiler_admin.services.google import USER_HELLO
 
 
 @pytest.fixture
@@ -57,4 +58,4 @@ def test_reset_password_notify(mock_google_user_exists, mock_google_CallGAMComma
     call_args = " ".join(mock_google_CallGAMCommand.call_args[0][0])
     assert "update user" in call_args
     assert "password random" in call_args
-    assert "notify [email protected] from [email protected]" in call_args
+    assert f"notify [email protected] from {USER_HELLO}" in call_args