Treat all warnings as errors (non wasm) (#88)

Author: mcbarton

.github/workflows/main.yml

@@ -99,6 +99,7 @@ jobs:
            -DCMAKE_PREFIX_PATH=$CONDA_PREFIX \
            -DCMAKE_INSTALL_PREFIX=$CONDA_PREFIX \
            -DXEUS_CPP_ENABLE_CODE_COVERAGE=${{ matrix.coverage }} \
+          -DCMAKE_COMPILE_WARNING_AS_ERROR=ON            \
            ${{ matrix.extra_cmake_flags }} 
 
       - name: build & install

CMakeLists.txt

@@ -6,7 +6,7 @@
 # The full license is in the file LICENSE, distributed with this software.  #
 #############################################################################
 
-cmake_minimum_required(VERSION 3.4.3)
+cmake_minimum_required(VERSION 3.24)
 project(xeus-cpp)
 
 enable_language(CXX)

src/xinterpreter.cpp

@@ -101,8 +101,8 @@ int __get_cxx_version () {
 __get_cxx_version ()
       )";
 
-      long cxx_version = Cpp::Evaluate(code);
-      return std::to_string(cxx_version);
+        auto cxx_version = Cpp::Evaluate(code);
+        return std::to_string(cxx_version);
     }
 
 
@@ -138,6 +138,9 @@ __get_cxx_version ()
     {
         nl::json kernel_res;
 
+
+        auto input_guard = input_redirection(allow_stdin);
+
         // Check for magics
         for (auto& pre : preamble_manager.preamble)
         {