Treat all warnings as errors (non wasm)

Author: mcbarton

.github/workflows/main.yml

@@ -227,6 +227,7 @@ jobs:
             -DCMAKE_INSTALL_PREFIX=$PREFIX                    \
             -DXEUS_CPP_EMSCRIPTEN_WASM_BUILD=ON               \
             -DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=ON            \
+            -DCMAKE_COMPILE_WARNING_AS_ERROR=false            \
             ..
           EMCC_CFLAGS='-sERROR_ON_UNDEFINED_SYMBOLS=0' emmake make -j  ${{ env.ncpus }}
 

CMakeLists.txt

@@ -47,6 +47,8 @@ OPTION(XEUS_CPP_BUILD_EXECUTABLE "Build the xcpp executable" ON)
 OPTION(XEUS_CPP_USE_SHARED_XEUS "Link xcpp  with the xeus shared library (instead of the static library)" ON)
 OPTION(XEUS_CPP_USE_SHARED_XEUS_CPP "Link xcpp  with the xeus shared library (instead of the static library)" ON)
 
+option(CMAKE_COMPILE_WARNING_AS_ERROR "Compile warnings as errors" ON)
+
 # Test options
 OPTION(XEUS_CPP_BUILD_TESTS "xeus-cpp test suite" ON)
 OPTION(XEUS_CPP_ENABLE_CODE_COVERAGE "xeus-cpp test suite" OFF)

src/xinterpreter.cpp

@@ -101,8 +101,8 @@ int __get_cxx_version () {
 __get_cxx_version ()
       )";
 
-      long cxx_version = Cpp::Evaluate(code);
-      return std::to_string(cxx_version);
+        auto cxx_version = Cpp::Evaluate(code);
+        return std::to_string(cxx_version);
     }
 
 
@@ -138,6 +138,9 @@ __get_cxx_version ()
     {
         nl::json kernel_res;
 
+
+        auto input_guard = input_redirection(allow_stdin);
+
         // Check for magics
         for (auto& pre : preamble_manager.preamble)
         {