Skip to content

Conversation

@kinow
Copy link
Member

@kinow kinow commented May 3, 2022

For common-workflow-language/common-workflow-language#914.

concepts.md is included by Workflow.yml and Process.yml, so the link should render OK. But I'll try to render it before marking as ready for review.

@kinow
Copy link
Member Author

kinow commented May 3, 2022

Huh? Did I merge it?

@kinow kinow reopened this May 3, 2022
@kinow
Copy link
Member Author

kinow commented May 3, 2022

Ah. I rebased onto the wrong branch, and then GitHub considered my branch as merged and closed it 😅 sweaty palms for a few seconds. All sorted out now, nothing to see here 👷

@kinow kinow force-pushed the opaque branch 2 times, most recently from d3519c1 to 2940190 Compare May 3, 2022 10:34
@kinow
Copy link
Member Author

kinow commented May 3, 2022

Table of Contents, now with the 1.7 Glossary entry.

image

Content rendered.

image

What links look like:

image

Tested each link generated, and all of them worked with no issues 👍 Ready for review.

@kinow kinow marked this pull request as ready for review May 3, 2022 10:39
@kinow
Copy link
Member Author

kinow commented May 3, 2022

And Today-I-Learned how to build our website. And also that we use cwltool to build the CWL website. That's meta! :neckbeard: 🤓

@mr-c mr-c requested a review from tetron May 3, 2022 11:17
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@kinow kinow added the documentation Improvements or additions to documentation label May 10, 2022
@kinow
Copy link
Member Author

kinow commented Jun 6, 2022

ping @tetron :)

@mr-c mr-c enabled auto-merge (rebase) June 21, 2022 12:38
@mr-c mr-c merged commit f05f8bc into 1.2.1_proposed Jun 21, 2022
@mr-c mr-c deleted the opaque branch June 21, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants