Add max and min attributes to number settings

Author: sheabunge

includes/settings/class-settings.php

@@ -68,6 +68,7 @@ private static function set_fields() {
 				'type' => 'number',
 				'label' => 'rows',
 				'default' => 5,
+				'min' => 0,
 			),
 
 			array(
@@ -114,6 +115,7 @@ private static function set_fields() {
 				'desc' => __( 'The width of a tab character.', 'code-snippets' ),
 				'default' => 4,
 				'codemirror' => 'tabSize',
+				'min' => 0,
 			),
 
 			array(
@@ -123,6 +125,7 @@ private static function set_fields() {
 				'desc' => __( 'How many spaces a block should be indented.', 'code-snippets' ),
 				'default' => 2,
 				'codemirror' => 'indentUnit',
+				'min' => 0,
 			),
 
 			array(

includes/settings/settings-fields.php

@@ -39,12 +39,22 @@ function code_snippets_checkbox_field( $atts ) {
 function code_snippets_number_field( $atts ) {
 
 	printf(
-		'<input type="number" name="code_snippets_settings[%s][%s]" value="%s">',
+		'<input type="number" name="code_snippets_settings[%s][%s]" value="%s"',
 		$atts['section'],
 		$atts['id'],
 		code_snippets_get_setting( $atts['section'], $atts['id'] )
 	);
 
+	if ( isset( $atts['min'] ) ) {
+		printf( ' min="%d"', $atts['min'] );
+	}
+
+	if ( isset( $atts['max'] ) ) {
+		printf( ' max="%d"', $atts['max'] );
+	}
+
+	echo '>';
+
 	if ( ! empty( $atts['label'] ) ) {
 		echo ' ' . $atts['label'];
 	}

includes/settings/settings.php

@@ -121,16 +121,18 @@ function code_snippets_register_settings() {
 	}
 
 	/* Register settings fields */
-	foreach ( code_snippets_get_settings_fields() as $section_id => $fields ) {
-
+	foreach ( Code_Snippets_Settings::get_fields() as $section_id => $fields ) {
 		foreach ( $fields as $field ) {
+			$atts = $field;
+			$atts['section'] = $section_id;
+
 			add_settings_field(
 				'code_snippets_' . $field['id'],
 				$field['name'],
 				"code_snippets_{$field['type']}_field",
 				'code-snippets',
 				'code-snippets-' . $section_id,
-				array_merge( $field, array( 'section' => $section_id ) )
+				$atts
 			);
 		}
 	}