From 34f37211f85b698db5b6750978786be47dbdf243 Mon Sep 17 00:00:00 2001 From: Danilo Woznica Date: Tue, 2 Aug 2022 11:35:33 +0100 Subject: [PATCH 1/3] fix(dashboard): prevent double click on editing --- .../src/app/pages/Dashboard/Components/Folder/FolderCard.tsx | 2 +- .../src/app/pages/Dashboard/Components/Sandbox/SandboxCard.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/app/src/app/pages/Dashboard/Components/Folder/FolderCard.tsx b/packages/app/src/app/pages/Dashboard/Components/Folder/FolderCard.tsx index 67d7b7588c7..a2bce52b0b9 100644 --- a/packages/app/src/app/pages/Dashboard/Components/Folder/FolderCard.tsx +++ b/packages/app/src/app/pages/Dashboard/Components/Folder/FolderCard.tsx @@ -31,7 +31,7 @@ export const FolderCard: React.FC = ({ direction="vertical" gap={2} onClick={onClick} - onDoubleClick={onDoubleClick} + onDoubleClick={editing ? undefined : onDoubleClick} onContextMenu={onContextMenu} {...props} css={css({ diff --git a/packages/app/src/app/pages/Dashboard/Components/Sandbox/SandboxCard.tsx b/packages/app/src/app/pages/Dashboard/Components/Sandbox/SandboxCard.tsx index 4ca3b17d0b9..2e01e99882d 100644 --- a/packages/app/src/app/pages/Dashboard/Components/Sandbox/SandboxCard.tsx +++ b/packages/app/src/app/pages/Dashboard/Components/Sandbox/SandboxCard.tsx @@ -247,7 +247,7 @@ export const SandboxCard = ({ Date: Tue, 2 Aug 2022 12:13:12 +0100 Subject: [PATCH 2/3] rerender renamed components --- .../src/app/pages/Dashboard/Components/VariableGrid/index.tsx | 3 ++- packages/app/src/app/pages/Profile/SandboxPicker/index.tsx | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/app/src/app/pages/Dashboard/Components/VariableGrid/index.tsx b/packages/app/src/app/pages/Dashboard/Components/VariableGrid/index.tsx index bc598b36a8d..498a3bd2d9a 100644 --- a/packages/app/src/app/pages/Dashboard/Components/VariableGrid/index.tsx +++ b/packages/app/src/app/pages/Dashboard/Components/VariableGrid/index.tsx @@ -80,6 +80,7 @@ interface IComponentForTypes { const ComponentForTypes: IComponentForTypes = { sandbox: React.memo(props => ( )), - folder: props => , + folder: props => , repo: props => , 'new-folder': props => , 'new-sandbox': () => , diff --git a/packages/app/src/app/pages/Profile/SandboxPicker/index.tsx b/packages/app/src/app/pages/Profile/SandboxPicker/index.tsx index 089b83cc794..0fb43dffed0 100644 --- a/packages/app/src/app/pages/Profile/SandboxPicker/index.tsx +++ b/packages/app/src/app/pages/Profile/SandboxPicker/index.tsx @@ -114,7 +114,7 @@ export const SandboxPicker: React.FC<{ closeModal?: () => void }> = ({ })} > {collectionsInPath.map(collection => ( - + setPath(collection.path)} From 575ae85bd767ea217a0eb8366371c7d2cccf9ddc Mon Sep 17 00:00:00 2001 From: Danilo Woznica Date: Tue, 2 Aug 2022 14:54:32 +0100 Subject: [PATCH 3/3] fix type --- .../src/app/pages/Dashboard/Components/VariableGrid/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/app/src/app/pages/Dashboard/Components/VariableGrid/index.tsx b/packages/app/src/app/pages/Dashboard/Components/VariableGrid/index.tsx index 498a3bd2d9a..b3ae0f9f635 100644 --- a/packages/app/src/app/pages/Dashboard/Components/VariableGrid/index.tsx +++ b/packages/app/src/app/pages/Dashboard/Components/VariableGrid/index.tsx @@ -80,7 +80,7 @@ interface IComponentForTypes { const ComponentForTypes: IComponentForTypes = { sandbox: React.memo(props => (